Fixes Global Node Prefix Error (#31740)

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Summary:
Some users have `node` installed globally which sets a `PREFIX` by default (so it knows where to put pkgs). We are looking for the "right" node on the next step anyway and if the user is using `nvm`, `PREFIX` breaks it.

closes https://github.com/facebook/react-native/issues/31181

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[General] [Fixed] - Ignores global npm prefix

Pull Request resolved: https://github.com/facebook/react-native/pull/31740

Test Plan:
`yarn ios` now works, even if there's a `usr/local/bin/npm`

<img width="493" alt="Screen Shot 2021-06-17 at 10 14 08 AM" src="https://user-images.githubusercontent.com/2659478/122413946-c2f57200-cf54-11eb-817c-bd3c07ac50bf.png">

Reviewed By: yungsters

Differential Revision: D31237363

Pulled By: charlesbdudley

fbshipit-source-id: 4ee9c04f8b8ab4e815bafbe2d02e589d621577b4

This commit is contained in:

Michael Neeley

2021-09-30 15:02:27 -07:00

committed by

Facebook GitHub Bot

parent 5c12a84c77

commit 6334ac35ac

1 changed files with 4 additions and 0 deletions

									
										scripts/find-node.sh
									
		+4
		
												View File
												
				@@ -6,6 +6,10 @@

				set -e

				# remove global prefix if it's already set

				# the running shell process will choose a node binary and a global package directory breaks version managers

				unset PREFIX

				# Support Homebrew on M1

				HOMEBREW_M1_BIN=/opt/homebrew/bin

				if [[ -d $HOMEBREW_M1_BIN && ! $PATH =~ $HOMEBREW_M1_BIN ]]; then