mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Add a check for scrollEnabled to VirtualizedList error (#34560)
Summary: Nested `VirtualizedList` is now an [error](https://github.com/facebook/react-native/commit/646605b90e666c4b0d1c1200a137eacf62b46f87), instead of a warning. Issues [here](https://github.com/facebook/react-native/issues/31697) and [here](https://github.com/facebook/react-native/issues/33024) outline the concern. ## Changelog [General] [Added] - Added a check to if `scrollEnabled` is not false, if so then fire the `VirtualizedList` error Pull Request resolved: https://github.com/facebook/react-native/pull/34560 Test Plan: Passes all provided automatic tests. In a personal app, there is a situation of nested ScrollViews that had triggered the error. After defining `scrollEnabled={false}` and adding the check, the error no longer appears. Reviewed By: yungsters Differential Revision: D39283866 Pulled By: NickGerleman fbshipit-source-id: 16ae6bbe6bb8b01a54ae18f9e6abf75d11c21c29
This commit is contained in:
committed by
Facebook GitHub Bot
parent
0ef770587f
commit
62f83a9fad
@@ -1101,7 +1101,8 @@ class VirtualizedList extends StateSafePureComponent<Props, State> {
|
||||
!scrollContext.horizontal ===
|
||||
!horizontalOrDefault(this.props.horizontal) &&
|
||||
!this._hasWarned.nesting &&
|
||||
this.context == null
|
||||
this.context == null &&
|
||||
this.props.scrollEnabled !== false
|
||||
) {
|
||||
// TODO (T46547044): use React.warn once 16.9 is sync'd: https://github.com/facebook/react/pull/15170
|
||||
console.error(
|
||||
|
||||
Reference in New Issue
Block a user