Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove deprecated uses of UIActivityIndicatorViewStyle (#38208)

Browse Source 
Summary:
Super simple change to replace some deprecated ENUM values with the correct one, now that we're on iOS 13.0+.

From `UIActivityIndicator.h`:
```
typedef NS_ENUM(NSInteger, UIActivityIndicatorViewStyle) {
    UIActivityIndicatorViewStyleMedium  API_AVAILABLE(ios(13.0), tvos(13.0)) = 100,
    UIActivityIndicatorViewStyleLarge   API_AVAILABLE(ios(13.0), tvos(13.0)) = 101,

    UIActivityIndicatorViewStyleWhiteLarge API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleLarge", ios(2.0, 13.0), tvos(9.0, 13.0)) = 0,
    UIActivityIndicatorViewStyleWhite API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0), tvos(9.0, 13.0)) = 1,
    UIActivityIndicatorViewStyleGray API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0)) API_UNAVAILABLE(tvos) = 2,
};
```

## Changelog:

[IOS] [CHANGED] - Remove deprecated uses of UIActivityIndicatorViewStyle

Pull Request resolved: https://github.com/facebook/react-native/pull/38208

Test Plan: CI should pass

Reviewed By: cipolleschi

Differential Revision: D47254035

Pulled By: rshest

fbshipit-source-id: 6d3270899e8d52611d91c777f324c3c6f0c520be
This commit is contained in:
Saad Najmi
2023-07-06 03:19:58 -07:00
committed by Facebook GitHub Bot
parent 28f4ebab8a
commit 62e9faefd5
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
+2 -2
View File
@@ -21,9 +21,9 @@ static UIActivityIndicatorViewStyle convertActivityIndicatorViewStyle(const Acti
{
switch (size) {
case ActivityIndicatorViewSize::Small:
return UIActivityIndicatorViewStyleWhite;
return UIActivityIndicatorViewStyleMedium;
case ActivityIndicatorViewSize::Large:
return UIActivityIndicatorViewStyleWhiteLarge;
return UIActivityIndicatorViewStyleLarge;
}
}
packages/react-native/React/Views/RCTActivityIndicatorViewManager.m
+3 -3
View File
@@ -18,10 +18,10 @@
RCT_ENUM_CONVERTER(
UIActivityIndicatorViewStyle,
(@{
@"large" : @(UIActivityIndicatorViewStyleWhiteLarge),
@"small" : @(UIActivityIndicatorViewStyleWhite),
@"large" : @(UIActivityIndicatorViewStyleLarge),
@"small" : @(UIActivityIndicatorViewStyleMedium),
}),
UIActivityIndicatorViewStyleWhiteLarge,
UIActivityIndicatorViewStyleLarge,
integerValue)
@end