Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when accessing _viewRegistry

Browse Source 
Summary:
Changelog: [internal] Fixes fabric specific crash

`_viewRegistry` is not thread safe and accessing it on another thread can cause a crash.
Calling it inside `RCTUnsafeExecuteOnMainQueueSync` shouldn't degrade performance because it is only used as a fallback.

Changelog: [Internal]

Reviewed By: rickhanlonii

Differential Revision: D18421789

fbshipit-source-id: 2adff434afe0a3c19318c95b051ee91ccf6293e5
This commit is contained in:
Samuel Susla
2019-11-11 03:01:26 -08:00
committed by Facebook Github Bot
parent 58726cee85
commit 620f83aae5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Modules/RCTUIManager.m
+4 -1
View File
@@ -335,7 +335,10 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation)
return name;
}
UIView *view = _viewRegistry[reactTag];
__block UIView *view;
RCTUnsafeExecuteOnMainQueueSync(^{
view = self->_viewRegistry[reactTag];
});
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wundeclared-selector"