mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Eliminate usage of more than 1-arg React.AbstractComponent in React codebase (#31314)
Summary: <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary In order to adopt react 19's ref-as-prop model, Flow needs to eliminate all the places where they are treated differently. `React.AbstractComponent` is the worst example of this, and we need to eliminate it. This PR eliminates them from the react repo, and only keeps the one that has 1 argument of props. ## How did you test this change? yarn flow DiffTrain build for [45804af18d589fd2c181f3b020f07661c46b73ea](https://github.com/facebook/react/commit/45804af18d589fd2c181f3b020f07661c46b73ea) Reviewed By: jbrown215 Differential Revision: D64725736 Pulled By: SamChou19815 fbshipit-source-id: c9f6f316c95d12a9ae98926faba111395b550ccf
This commit is contained in:
committed by
Facebook GitHub Bot
parent
363818ea20
commit
6205aad81e
@@ -7,15 +7,10 @@
|
||||
* @noformat
|
||||
* @nolint
|
||||
* @flow strict
|
||||
* @generated SignedSource<<448b89d0a61a392d9c1eb921f7d51d37>>
|
||||
* @generated SignedSource<<9cf3e28d6ca0299bc0bb5caa75b19556>>
|
||||
*/
|
||||
|
||||
import type {
|
||||
ElementRef,
|
||||
ElementType,
|
||||
MixedElement,
|
||||
AbstractComponent,
|
||||
} from 'react';
|
||||
import type {ElementRef, ElementType, MixedElement} from 'react';
|
||||
|
||||
export type MeasureOnSuccessCallback = (
|
||||
x: number,
|
||||
@@ -138,7 +133,9 @@ declare const ensureNativeMethodsAreSynced: NativeMethods;
|
||||
(ensureNativeMethodsAreSynced: INativeMethods);
|
||||
|
||||
export type HostInstance = NativeMethods;
|
||||
export type HostComponent<Config> = AbstractComponent<Config, HostInstance>;
|
||||
/*::
|
||||
export type HostComponent<Config: {...}> = component(ref: React$RefSetter<HostInstance>, ...Config);
|
||||
*/
|
||||
|
||||
type InspectorDataProps = $ReadOnly<{
|
||||
[propName: string]: string,
|
||||
@@ -209,8 +206,10 @@ export type ReactNativeType = {
|
||||
componentOrHandle: ?(ElementRef<TElementType> | number),
|
||||
): ?number,
|
||||
isChildPublicInstance(
|
||||
parent: PublicInstance | HostComponent<mixed>,
|
||||
child: PublicInstance | HostComponent<mixed>,
|
||||
// eslint-disable-next-line no-undef
|
||||
parent: PublicInstance | HostComponent<empty>,
|
||||
// eslint-disable-next-line no-undef
|
||||
child: PublicInstance | HostComponent<empty>,
|
||||
): boolean,
|
||||
dispatchCommand(
|
||||
handle: HostInstance,
|
||||
|
||||
Reference in New Issue
Block a user