mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Detect formatted React.createClass calls (#58256)
Summary: The source-optimized preset enables React's display-name transform only when the exact bytes `React.createClass` are present. Valid comments or whitespace around the member access, such as `React /* comment */ . createClass(...)`, bypass the transform and omit the inferred component `displayName`, unlike the full preset path. Use the stable `createClass` identifier token as the cheap source probe while retaining the separate `createReactClass` probe. Formatting no longer changes output; unrelated token matches only enable an otherwise no-op Babel visitor. ## Changelog: [GENERAL] [FIXED] - Detect trivia-separated React.createClass calls in optimized preset configuration. Pull Request resolved: https://github.com/react/react-native/pull/58256 Test Plan: - Added an optimized-source regression with comment/whitespace-separated member access. - Exact baseline omits `displayName`; the fixed transform emits `displayName: "Component"`. - Full preset Jest passes: 4/4 suites, 111/111 tests, 16 snapshots. - Fresh Flow check reports 0 errors. - Targeted no-ignore ESLint, Prettier, and `git diff --check` pass. No public API or breaking behavior change; optimized and full preset paths now agree for valid formatting. Reviewed By: GijsWeterings Differential Revision: D118266439 Pulled By: javache fbshipit-source-id: 802fe1c8cadda18931384cd5a7f6e88a63e87bad
This commit is contained in:
1 parent
1b404433f8
commit
619c8aed24
2 files changed
+26
-1
No files matched your search
@@ -171,6 +171,21 @@ function transformCode(
|
||||
return result?.code ?? null;
|
||||
}
|
||||
|
||||
function transformCodeWithSourceOptimization(
|
||||
code: string,
|
||||
options: {[string]: unknown},
|
||||
): string | null {
|
||||
const config = preset.getPreset(code, options);
|
||||
const result = babel.transformSync(code, {
|
||||
...config,
|
||||
babelrc: false,
|
||||
configFile: false,
|
||||
filename: MOCK_FILENAME,
|
||||
sourceMaps: false,
|
||||
});
|
||||
return result?.code ?? null;
|
||||
}
|
||||
|
||||
function getSnapshotPath(configName: string): string {
|
||||
return path.join(OUTPUT_DIR, `${configName}.js`);
|
||||
}
|
||||
@@ -267,6 +282,16 @@ describe('react-native-babel-preset transform snapshots', () => {
|
||||
);
|
||||
|
||||
describe('specific feature transformations', () => {
|
||||
it('adds display names when React.createClass contains trivia', () => {
|
||||
const code = `
|
||||
const Component = React /* comment */ . createClass({
|
||||
render() { return null; }
|
||||
});
|
||||
`;
|
||||
const result = transformCodeWithSourceOptimization(code, {dev: false});
|
||||
expect(result).toContain('displayName:"Component"');
|
||||
});
|
||||
|
||||
it('handles async generators', () => {
|
||||
const code = `
|
||||
async function* gen() {
|
||||
|
||||
+1
-1
@@ -190,7 +190,7 @@ const getPreset = (src, options, babel) => {
|
||||
}
|
||||
if (
|
||||
isNull ||
|
||||
src.indexOf('React.createClass') !== -1 ||
|
||||
src.indexOf('createClass') !== -1 ||
|
||||
src.indexOf('createReactClass') !== -1
|
||||
) {
|
||||
extraPlugins.push([require('@babel/plugin-transform-react-display-name')]);
|
||||
|
||||
Reference in new issue
Block a user