Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set default XMLHttpRequest trackingName to undefined (#51656)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51656

This fixes an issue with the internal networking layer when `enableModuleArgumentNSNullConversionIOS` is enabled, as we'd try to  pass `NSNull` as trackingName instead of omitting it.
`
Changelog: [Internal]

Reviewed By: fabriziocucci

Differential Revision: D75516619

fbshipit-source-id: 91a3bba32772fdd66edde1e24b7edd977918f727
This commit is contained in:
Pieter De Baets
2025-05-28 05:41:51 -07:00
committed by Facebook GitHub Bot
parent 66730ae59e
commit 618ed98882
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Network/XMLHttpRequest.js
Vendored
+2 -2
View File
@@ -170,7 +170,7 @@ class XMLHttpRequest extends EventTarget {
_sent: boolean;
_url: ?string = null;
_timedOut: boolean = false;
_trackingName: ?string = null;
_trackingName: string | void = undefined;
_incrementalEvents: boolean = false;
_startTime: ?number = null;
_performanceLogger: IPerformanceLogger = GlobalPerformanceLogger;
@@ -534,7 +534,7 @@ class XMLHttpRequest extends EventTarget {
/**
* Custom extension for tracking origins of request.
*/
setTrackingName(trackingName: ?string): XMLHttpRequest {
setTrackingName(trackingName: string | void): XMLHttpRequest {
this._trackingName = trackingName;
return this;
}
packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
+1 -1
View File
@@ -6009,7 +6009,7 @@ declare class XMLHttpRequest extends EventTarget {
getAllResponseHeaders(): ?string;
getResponseHeader(header: string): ?string;
setRequestHeader(header: string, value: any): void;
setTrackingName(trackingName: ?string): XMLHttpRequest;
setTrackingName(trackingName: string | void): XMLHttpRequest;
setPerformanceLogger(performanceLogger: IPerformanceLogger): XMLHttpRequest;
open(method: string, url: string, async: ?boolean): void;
send(data: any): void;