mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41807 Changelog: [Internal] Follow-up on https://github.com/facebook/react/pull/27783. React Native is actually using `ReactNativeTypes`, which are synced from this repo. In order to make `isChildPublicInstance` visible for renderers inside React Native repository, we need to list it in `ReactNativeTypes`. Because of current circular dependency between React Native and React, it is impossible to actually type it properly: - Can't import any types in `ReactNativeTypes` from local files, because it will break React Native, once synced. - Implementations can't use real types in their definitions, because it will break these checks: https://github.com/facebook/react/blob/223db40d5a04dc3311f963f5296675f7f43139e8/packages/react-native-renderer/fabric.js#L12-L13 https://github.com/facebook/react/blob/223db40d5a04dc3311f963f5296675f7f43139e8/packages/react-native-renderer/index.js#L12-L14 DiffTrain build for commit https://github.com/facebook/react/commit/c29ca23af91d8aeb9e175c08a0866ba54286f0f3. Test Plan: Sandcastle tests Reviewed By: kassens Differential Revision: D51849040 Pulled By: hoxyq fbshipit-source-id: f75593e44c114289ad4c6fb8b4b37c4c5fd6d3d4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
73d0cf502d
commit
616a907798
@@ -7,7 +7,7 @@
|
||||
* @noformat
|
||||
* @flow strict
|
||||
* @nolint
|
||||
* @generated SignedSource<<1836a1b6639552dce12199ef2c85f63d>>
|
||||
* @generated SignedSource<<30640e7dd83e22e14db1648ca63f4316>>
|
||||
*/
|
||||
|
||||
import type {ElementRef, ElementType, Element, AbstractComponent} from 'react';
|
||||
@@ -193,6 +193,10 @@ export type ReactNativeType = {
|
||||
findNodeHandle<TElementType: ElementType>(
|
||||
componentOrHandle: ?(ElementRef<TElementType> | number),
|
||||
): ?number,
|
||||
isChildPublicInstance(
|
||||
parent: PublicInstance | HostComponent<mixed>,
|
||||
child: PublicInstance | HostComponent<mixed>,
|
||||
): boolean,
|
||||
dispatchCommand(
|
||||
handle: ElementRef<HostComponent<mixed>>,
|
||||
command: string,
|
||||
@@ -231,6 +235,7 @@ export type ReactFabricType = {
|
||||
command: string,
|
||||
args: Array<mixed>,
|
||||
): void,
|
||||
isChildPublicInstance(parent: PublicInstance, child: PublicInstance): boolean,
|
||||
sendAccessibilityEvent(
|
||||
handle: ElementRef<HostComponent<mixed>>,
|
||||
eventType: string,
|
||||
|
||||
Reference in New Issue
Block a user