Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing accessibilityTraits in Fabric

Browse Source 
Summary:
`accessibilityTraits` was missing, this diff adds it.

Also there is a name mis match, in javascript it is called `accessibilityRole`.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D18857668

fbshipit-source-id: 10656e8fb4e8c1d771a72c7f354b845e41cfc313
This commit is contained in:
Samuel Susla
2019-12-09 06:41:27 -08:00
committed by Facebook Github Bot
parent 9bb042fe58
commit 5ee8202b26
3 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
+5
View File
@@ -229,6 +229,11 @@ using namespace facebook::react;
self.accessibilityElement.accessibilityElementsHidden = newViewProps.accessibilityElementsHidden;
}
if (oldViewProps.accessibilityTraits != newViewProps.accessibilityTraits) {
self.accessibilityElement.accessibilityTraits =
RCTUIAccessibilityTraitsFromAccessibilityTraits(newViewProps.accessibilityTraits);
}
// `accessibilityIgnoresInvertColors`
if (oldViewProps.accessibilityIgnoresInvertColors != newViewProps.accessibilityIgnoresInvertColors) {
#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000 /* __IPHONE_11_0 */
ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp
+4
View File
@@ -20,6 +20,10 @@ AccessibilityProps::AccessibilityProps(
RawProps const &rawProps)
: accessible(
convertRawProp(rawProps, "accessible", sourceProps.accessible)),
accessibilityTraits(convertRawProp(
rawProps,
"accessibilityRole",
sourceProps.accessibilityTraits)),
accessibilityLabel(convertRawProp(
rawProps,
"accessibilityLabel",
ReactCommon/fabric/components/view/accessibility/accessibilityPropsConversions.h
+11 -2
View File
@@ -38,7 +38,7 @@ inline void fromString(const std::string &string, AccessibilityTraits &result) {
result = AccessibilityTraits::PlaysSound;
return;
}
if (string == "keyboardkey") {
if (string == "keyboardkey" || string == "key") {
result = AccessibilityTraits::KeyboardKey;
return;
}
@@ -78,7 +78,16 @@ inline void fromString(const std::string &string, AccessibilityTraits &result) {
result = AccessibilityTraits::Header;
return;
}
abort();
if (string == "imagebutton") {
result = AccessibilityTraits::Image | AccessibilityTraits::Button;
return;
}
if (string == "summary") {
result = AccessibilityTraits::SummaryElement;
return;
}
result = AccessibilityTraits::None;
}
inline void fromRawValue(const RawValue &value, AccessibilityTraits &result) {