Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assert enableBridgelessArchitecture is true when starting Bridgeless (#47145)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/47145

Staring Bridgeless without previously setting ReactNativeFeatureFlags.enableBridgelessArchitecture() is UB, we should assert enableBridgelessArchitecture is true when starting Bridgeless

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D64641081

fbshipit-source-id: d7964f8a9d5a2e6dad9d44b8fd5cd5a52d1b2cf4
This commit is contained in:
David Vacca
2024-10-23 22:53:44 -07:00
committed by Facebook GitHub Bot
parent 2d97a6ccb0
commit 5e21232717
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java
+11
View File
@@ -923,6 +923,17 @@ public class ReactHostImpl implements ReactHost {
final String method = "getOrCreateStartTask()";
if (mStartTask == null) {
log(method, "Schedule");
Assertions.assertCondition(
ReactNativeFeatureFlags.enableBridgelessArchitecture(),
"enableBridgelessArchitecture FeatureFlag must be set to start ReactNative.");
Assertions.assertCondition(
ReactNativeFeatureFlags.enableFabricRenderer(),
"enableFabricRenderer FeatureFlag must be set to start ReactNative.");
Assertions.assertCondition(
ReactNativeFeatureFlags.useTurboModules(),
"useTurboModules FeatureFlag must be set to start ReactNative.");
mStartTask =
waitThenCallGetOrCreateReactInstanceTask()
.continueWithTask(