mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Use the default build task rather than buildAll
Summary: We can now use the `build` lifecycle task rather than a custom buildAll. This task will also run linters and other checks on our builds. Speficially I realized we were missing some permission in the manifest of RN-Tester which were missed once we bumped to SDK 33. Changelog: [Internal] [Changed] - Use the default `build` task rather than `buildAll` Reviewed By: cipolleschi Differential Revision: D44055845 fbshipit-source-id: c9adbbeaaaf7ab8a8000fc1dce84ec39427fb26e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
a389373442
commit
5cbabe30d3
@@ -790,7 +790,7 @@ jobs:
|
||||
|
||||
- run:
|
||||
name: Build & Test React Native using Gradle
|
||||
command: ./gradlew buildAll
|
||||
command: ./gradlew build
|
||||
|
||||
- report_bundle_size:
|
||||
platform: android
|
||||
|
||||
+1
-10
@@ -65,18 +65,9 @@ tasks.register("cleanAll", Delete::class.java) {
|
||||
delete(rootProject.file("./packages/rn-tester/android/app/.cxx"))
|
||||
}
|
||||
|
||||
tasks.register("buildAll") {
|
||||
tasks.register("build") {
|
||||
description = "Build and test all the React Native relevant projects."
|
||||
dependsOn(gradle.includedBuild("react-native-gradle-plugin").task(":build"))
|
||||
// This builds both the React Native framework for both debug and release
|
||||
dependsOn(":packages:react-native:ReactAndroid:assemble")
|
||||
// This creates all the Maven artifacts and makes them available in the /android folder
|
||||
dependsOn(":packages:react-native:ReactAndroid:installArchives")
|
||||
// This builds RN Tester for Hermes/JSC for debug and release
|
||||
dependsOn(":packages:rn-tester:android:app:assemble")
|
||||
// Runs Unit tests for both ReactAndroid and RN-Tester
|
||||
dependsOn(":packages:react-native:ReactAndroid:test")
|
||||
dependsOn(":packages:rn-tester:android:app:test")
|
||||
}
|
||||
|
||||
tasks.register("downloadAll") {
|
||||
|
||||
@@ -8,10 +8,17 @@
|
||||
<uses-feature
|
||||
android:name="android.hardware.touchscreen"
|
||||
android:required="false" />
|
||||
<uses-feature
|
||||
android:name="android.hardware.location.gps"
|
||||
android:required="false" />
|
||||
<uses-feature
|
||||
android:name="android.hardware.camera"
|
||||
android:required="false" />
|
||||
|
||||
<uses-permission android:name="android.permission.INTERNET" />
|
||||
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
|
||||
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
|
||||
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
|
||||
<uses-permission android:name="android.permission.VIBRATE"/>
|
||||
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
|
||||
|
||||
|
||||
Reference in New Issue
Block a user