Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use findByName instead of named when applying Gradle task dependencies

Browse Source 
Summary:
When using Android Studio, an active ABI gets selected which is resulting in failing to open the project as some of the tasks can't be found. I'm fixing this.

Changelog:
[Internal] [Changed] - Use `findByName` instead of `named` when applying Gradle task dependencies

Reviewed By: ShikaSD

Differential Revision: D35044870

fbshipit-source-id: 44bfaee320bce84c992610325c13daf71934a38b
This commit is contained in:
Nicola Corti
2022-03-22 04:48:52 -07:00
committed by Facebook GitHub Bot
parent c1cb21d582
commit 5b1ac6fb3b
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/build.gradle
+4 -4
View File
@@ -408,8 +408,8 @@ afterEvaluate {
// Needed as some of the native sources needs to be downloaded
// before configureNdkBuildDebug could be executed.
reactNativeArchitectures().each { architecture ->
tasks.named("configureNdkBuildDebug[${architecture}]") { dependsOn(preBuild) }
tasks.named("configureNdkBuildRelease[${architecture}]") { dependsOn(preBuild) }
tasks.findByName("configureNdkBuildDebug[${architecture}]")?.configure { dependsOn(preBuild) }
tasks.findByName("configureNdkBuildRelease[${architecture}]")?.configure { dependsOn(preBuild) }
}
configureNdkBuildDebug.dependsOn(preBuild)
configureNdkBuildRelease.dependsOn(preBuild)
@@ -424,8 +424,8 @@ afterEvaluate {
configureNdkBuildDebug.dependsOn(":ReactAndroid:hermes-engine:prefabDebugPackage")
configureNdkBuildRelease.dependsOn(":ReactAndroid:hermes-engine:prefabReleasePackage")
reactNativeArchitectures().each { architecture ->
tasks.named("configureNdkBuildDebug[${architecture}]") { dependsOn(":ReactAndroid:hermes-engine:prefabDebugPackage") }
tasks.named("configureNdkBuildRelease[${architecture}]") { dependsOn(":ReactAndroid:hermes-engine:prefabReleasePackage") }
tasks.findByName("configureNdkBuildDebug[${architecture}]")?.configure { dependsOn(":ReactAndroid:hermes-engine:prefabDebugPackage") }
tasks.findByName("configureNdkBuildRelease[${architecture}]")?.configure { dependsOn(":ReactAndroid:hermes-engine:prefabReleasePackage") }
}
publishing {
ReactAndroid/hermes-engine/build.gradle
+2 -2
View File
@@ -219,8 +219,8 @@ afterEvaluate {
// Needed as some of the native sources needs to be downloaded
// before configureCMakeRelease/configureCMakeMinSizeRel could be executed.
reactNativeArchitectures().each { architecture ->
tasks.named("configureCMakeMinSizeRel[${architecture}]") { dependsOn(preBuild) }
tasks.named("configureCMakeRelease[${architecture}]") { dependsOn(preBuild) }
tasks.findByName("configureCMakeMinSizeRel[${architecture}]")?.configure { dependsOn(preBuild) }
tasks.findByName("configureCMakeRelease[${architecture}]")?.configure { dependsOn(preBuild) }
}
configureCMakeRelease.dependsOn(preBuild)
configureCMakeMinSizeRel.dependsOn(preBuild)
packages/rn-tester/android/app/build.gradle
+2 -2
View File
@@ -300,11 +300,11 @@ if (enableCodegen) {
afterEvaluate {
reactNativeArchitectures().each { architecture ->
tasks.named("configureNdkBuildDebug[${architecture}]") {
tasks.findByName("configureNdkBuildDebug[${architecture}]")?.configure {
dependsOn("preHermesDebugBuild")
dependsOn("preJscDebugBuild")
}
tasks.named("configureNdkBuildRelease[${architecture}]") {
tasks.findByName("configureNdkBuildRelease[${architecture}]")?.configure {
dependsOn("preHermesReleaseBuild")
dependsOn("preJscReleaseBuild")
}