mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Move shadow-node ref update thread tag to Fabric install (#57497)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57497 The runtime shadow-node reference update thread tag was being set on every `RuntimeExecutor` tick in `ReactInstance`. Because the underlying flag is `thread_local` and only meaningful on the JS runtime thread, it's enough to set it once during Fabric installation. Move the `ShadowNode::setUseRuntimeShadowNodeReferenceUpdateOnThread` call into `UIManagerBinding::createAndInstallIfNeeded`, which runs on the JS thread and is guarded to execute once per runtime. This lets the `runtime` module drop its direct dependency on `renderer/core`, reducing coupling between the Bridgeless runtime host and the Fabric renderer. Behavior is unchanged: the write was already unconditional; the read at `updateMountedFlag` is still gated by the existing feature flag. Changelog: [Internal] Reviewed By: lenaic, zeyap Differential Revision: D111059967 fbshipit-source-id: e38a16f75ba972c214cd92637caf0441ee6a734e
This commit is contained in:
1 parent
d70113ff6e
commit
5976273f1c
2 files changed
+7
-2
No files matched your search
@@ -13,6 +13,7 @@
|
||||
#include <react/debug/react_native_assert.h>
|
||||
#include <react/renderer/components/view/PointerEvent.h>
|
||||
#include <react/renderer/core/LayoutableShadowNode.h>
|
||||
#include <react/renderer/core/ShadowNode.h>
|
||||
#include <react/renderer/dom/DOM.h>
|
||||
#include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
|
||||
#include <react/renderer/uimanager/primitives.h>
|
||||
@@ -35,6 +36,12 @@ void UIManagerBinding::createAndInstallIfNeeded(
|
||||
auto object = jsi::Object::createFromHostObject(runtime, uiManagerBinding);
|
||||
runtime.global().setProperty(
|
||||
runtime, uiManagerModuleName, std::move(object));
|
||||
|
||||
// Tag this thread (the JS runtime thread) as the one allowed to propagate
|
||||
// runtime shadow-node reference updates during Fabric commit. The flag is
|
||||
// thread_local, so it must be set on the JS thread; installing the binding
|
||||
// is guaranteed to run there and to happen before any JS-driven commit.
|
||||
ShadowNode::setUseRuntimeShadowNodeReferenceUpdateOnThread(true);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -18,7 +18,6 @@
|
||||
#include <jsi/instrumentation.h>
|
||||
#include <jsinspector-modern/HostTarget.h>
|
||||
#include <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#include <react/renderer/core/ShadowNode.h>
|
||||
#include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
|
||||
#include <react/runtime/JSRuntimeBindings.h>
|
||||
#include <react/timing/primitives.h>
|
||||
@@ -98,7 +97,6 @@ ReactInstance::ReactInstance(
|
||||
jsi::Runtime& jsiRuntime = runtime->getRuntime();
|
||||
TraceSection s("ReactInstance::_runtimeExecutor[Callback]");
|
||||
try {
|
||||
ShadowNode::setUseRuntimeShadowNodeReferenceUpdateOnThread(true);
|
||||
callback(jsiRuntime);
|
||||
} catch (jsi::JSError& originalError) {
|
||||
jsErrorHandler->handleError(jsiRuntime, originalError, true);
|
||||
|
||||
Reference in new issue
Block a user