mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix TS Type for measureLayout optional parameter
Summary: Encountered this, causing typechecking to fail on an example in the current RN documentation. `onFail` is an optional parameter (see https://github.com/facebook/react/blob/8e2bde6f2751aa6335f3cef488c05c3ea08e074a/packages/react-native-renderer/src/ReactNativeTypes.js#L106), which is not optional in current TS types. Update the TS typings to match. Note that "?" here is positioned to be a Flow optional parameter, instead of a maybe type. Which means it accepts undefined, but not null, matching the TS usage of "?" which always means possibly undefined (but never null, like a flow maybe type allows). Changelog: [General][Fixed] - Fix TS Type for measureLayout optional parameter Reviewed By: lunaleaps Differential Revision: D41775900 fbshipit-source-id: 8f53428b8077ec9139c7c1bbc60ed20f5fa9f7ea
This commit is contained in:
committed by
Facebook GitHub Bot
parent
0df2530c9e
commit
5928144302
Vendored
+4
-2
@@ -86,9 +86,11 @@ export interface NativeMethods {
|
||||
* _Can also be called with a relativeNativeNodeHandle but is deprecated._
|
||||
*/
|
||||
measureLayout(
|
||||
relativeToNativeComponentRef: HostComponent<unknown> | number,
|
||||
relativeToNativeComponentRef:
|
||||
| React.ElementRef<HostComponent<unknown>>
|
||||
| number,
|
||||
onSuccess: MeasureLayoutOnSuccessCallback,
|
||||
onFail: () => void /* currently unused */,
|
||||
onFail?: () => void,
|
||||
): void;
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user