Fix XMLHttpRequest.setRequestHeader to append duplicate headers per spec

Summary:
`XMLHttpRequest.setRequestHeader()` overwrites the previous value when called multiple times with the same header name. Per the [XHR Living Standard §4.5.2](https://xhr.spec.whatwg.org/#the-setrequestheader()-method), duplicate headers should be appended with `, `.

Real-world example: [Sentry JS SDK assumes append behavior](https://github.com/getsentry/sentry-javascript/blob/10.38.0/packages/browser/src/tracing/request.ts#L440-L445)
when setting the `baggage` header, which causes previously set baggage values to be silently dropped on React Native.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[GENERAL] [FIXED] - Fix XMLHttpRequest.setRequestHeader to append duplicate headers per spec

> **Note:** This is technically a breaking change for code that relied on the previous overwrite behavior (e.g., calling `setRequestHeader` twice to replace a value). However, that behavior was non-compliant with the XHR spec, so such code should use a single call with the desired final value instead.

X-link: https://github.com/facebook/react-native/pull/56394

Reviewed By: huntie, cipolleschi

Differential Revision: D100144689

Pulled By: fabriziocucci

fbshipit-source-id: 0697d88e02f76285ff50e339b0c25cda8337c36c
This commit is contained in:
김민규(Mingyu Kim) authored and meta-codesync[bot] committed 2026-07-30 14:38:57 -07:00
1 parent aadcadeec7
commit 58bf844967
2 files changed
+37 -1

No files matched your search

+4 -1
View File
@@ -513,7 +513,10 @@ class XMLHttpRequest extends EventTarget {
if (this.readyState !== this.OPENED) {
throw new Error('Request has not been opened');
}
this._headers[header.toLowerCase()] = String(value);
const key = header.toLowerCase();
const existing = this._headers[key];
this._headers[key] =
existing !== undefined ? existing + ', ' + String(value) : String(value);
}
/**
@@ -268,6 +268,39 @@ describe('XMLHttpRequest', function () {
);
});
it('should append values when setRequestHeader is called with the same header', function () {
xhr.open('GET', 'blabla');
xhr.setRequestHeader('X-Custom', 'value1');
xhr.setRequestHeader('X-Custom', 'value2');
// $FlowFixMe[prop-missing]
expect(xhr._headers['x-custom']).toBe('value1, value2');
});
it('should append to a header previously set to an empty string', function () {
xhr.open('GET', 'blabla');
xhr.setRequestHeader('X-Custom', '');
xhr.setRequestHeader('X-Custom', 'value');
// $FlowFixMe[prop-missing]
expect(xhr._headers['x-custom']).toBe(', value');
});
it('should lowercase header names in setRequestHeader', function () {
xhr.open('GET', 'blabla');
xhr.setRequestHeader('Content-Type', 'application/json');
xhr.setRequestHeader('content-type', 'text/plain');
// $FlowFixMe[prop-missing]
expect(xhr._headers['content-type']).toBe('application/json, text/plain');
});
it('should throw when setRequestHeader is called before open', function () {
expect(() => {
xhr.setRequestHeader('foo', 'bar');
}).toThrow('Request has not been opened');
});
it('should sort and lowercase response headers', function () {
// Derived from XHR Web Platform Test: https://github.com/web-platform-tests/wpt/blob/master/xhr/getallresponseheaders.htm
xhr.open('GET', 'blabla');