Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not mutate output of flattenStyle in TextInput (#45348)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45348

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D59525418

fbshipit-source-id: 094b7c9c952d8684e24203cc07d6bda51bdf12b5
This commit is contained in:
Pieter De Baets
2024-07-09 15:58:12 -07:00
committed by Facebook GitHub Bot
parent 2bed2ab1a6
commit 57e3451557
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Components/TextInput/TextInput.js
Vendored
+3 -5
View File
@@ -1535,12 +1535,10 @@ function InternalTextInput(props: Props): React.Node {
};
}
const style = flattenStyle<TextStyleProp>(props.style);
let style = flattenStyle<TextStyleProp>(props.style);
if (typeof style?.fontWeight === 'number') {
// $FlowFixMe[prop-missing]
// $FlowFixMe[cannot-write]
style.fontWeight = style?.fontWeight.toString();
// $FlowFixMe
style = [style, {fontWeight: style.fontWeight.toString()}];
}
if (Platform.OS === 'ios') {