Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't pass around react context in react package if it's not needed (#36711)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36711

Changelog: [Internal]

minimizing callsites to the react context, which has turned into a bloated toolbox class

Reviewed By: javache

Differential Revision: D44493500

fbshipit-source-id: 7272b18af96103dee3658d151fd8e9f03846bd09
This commit is contained in:
Phillip Pan
2023-03-30 15:20:59 -07:00
committed by Facebook GitHub Bot
parent c62fca7525
commit 5457811a16
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/DebugCorePackage.java
+4 -4
View File
@@ -99,7 +99,7 @@ public class DebugCorePackage extends TurboReactPackage implements ViewManagerOn
}
/** @return a map of view managers that should be registered with {@link UIManagerModule} */
private Map<String, ModuleSpec> getViewManagersMap(final ReactApplicationContext reactContext) {
private Map<String, ModuleSpec> getViewManagersMap() {
if (mViewManagers == null) {
Map<String, ModuleSpec> viewManagers = new HashMap<>();
appendMap(
@@ -119,18 +119,18 @@ public class DebugCorePackage extends TurboReactPackage implements ViewManagerOn
@Override
public List<ModuleSpec> getViewManagers(ReactApplicationContext reactContext) {
return new ArrayList<>(getViewManagersMap(reactContext).values());
return new ArrayList<>(getViewManagersMap().values());
}
@Override
public Collection<String> getViewManagerNames(ReactApplicationContext reactContext) {
return getViewManagersMap(reactContext).keySet();
return getViewManagersMap().keySet();
}
@Override
public @Nullable ViewManager createViewManager(
ReactApplicationContext reactContext, String viewManagerName) {
ModuleSpec spec = getViewManagersMap(reactContext).get(viewManagerName);
ModuleSpec spec = getViewManagersMap().get(viewManagerName);
return spec != null ? (ViewManager) spec.getProvider().get() : null;
}
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java
+4 -4
View File
@@ -187,7 +187,7 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
}
/** @return a map of view managers that should be registered with {@link UIManagerModule} */
public Map<String, ModuleSpec> getViewManagersMap(final ReactApplicationContext reactContext) {
public Map<String, ModuleSpec> getViewManagersMap() {
if (mViewManagers == null) {
Map<String, ModuleSpec> viewManagers = new HashMap<>();
appendMap(
@@ -341,18 +341,18 @@ public class MainReactPackage extends TurboReactPackage implements ViewManagerOn
@Override
public List<ModuleSpec> getViewManagers(ReactApplicationContext reactContext) {
return new ArrayList<>(getViewManagersMap(reactContext).values());
return new ArrayList<>(getViewManagersMap().values());
}
@Override
public Collection<String> getViewManagerNames(ReactApplicationContext reactContext) {
return getViewManagersMap(reactContext).keySet();
return getViewManagersMap().keySet();
}
@Override
public @Nullable ViewManager createViewManager(
ReactApplicationContext reactContext, String viewManagerName) {
ModuleSpec spec = getViewManagersMap(reactContext).get(viewManagerName);
ModuleSpec spec = getViewManagersMap().get(viewManagerName);
return spec != null ? (ViewManager) spec.getProvider().get() : null;
}