Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass execution context ID in Debugger.scriptParsed event (#34640)

Browse Source 
Summary:
As generated by ReactCommon code, the CDP [Debugger.scriptParsed](https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#event-scriptParsed) event carries a zero execution context ID. It should match the execution context ID contained in the []() argument of the [Runtime.executionContextCreated](https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#event-executionContextCreated) event. Tracking issue is RN:34639](https://github.com/facebook/react-native/issues/34639).

## Changelog

[General] [Changed] - Correct execution context ID in Debugger.scriptParsed event.

Pull Request resolved: https://github.com/facebook/react-native/pull/34640

Test Plan: Verified via packet tracer (Wireshark, Chrome DevTools protocol monitor) that Debugger.scriptParsed carries execution context ID.

Reviewed By: jpporto

Differential Revision: D39385622

Pulled By: mattbfb

fbshipit-source-id: 9060041cfa2a784adf4ad371fbe63f530e3362ad
This commit is contained in:
Andreas Eulitz
2022-09-12 06:41:21 -07:00
committed by Facebook GitHub Bot
parent 09a910f80b
commit 545366aea3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/hermes/inspector/chrome/Connection.cpp
+1 -2
View File
@@ -390,8 +390,7 @@ void Connection::Impl::onScriptParsed(
m::debugger::ScriptParsedNotification note;
note.scriptId = folly::to<std::string>(info.fileId);
note.url = info.fileName;
// TODO(jpporto): fix test cases sending invalid context id.
// note.executionContextId = kHermesExecutionContextId;
note.executionContextId = kHermesExecutionContextId;
if (!info.sourceMappingUrl.empty()) {
note.sourceMapURL = info.sourceMappingUrl;