mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Make sure the template project name is helloworld_appmodules (#34417)
Summary: Make sure the new app template uses the correct project CMake project name: `helloworld_appmodules`, otherwise the app will fail to load the dynamic library. This was a copy-n-paste error from RNTester. ## Changelog [Internal] - Make sure the template project name is `helloworld_appmodules` Pull Request resolved: https://github.com/facebook/react-native/pull/34417 Test Plan: Will test an app created with the New App template Reviewed By: cipolleschi Differential Revision: D38698682 Pulled By: cortinico fbshipit-source-id: b09331a52989b3b131ea8ba627057febcb535ef8
This commit is contained in:
committed by
Lorenzo Sciandra
parent
0b4b7774e2
commit
5367459233
@@ -1,7 +1,7 @@
|
||||
cmake_minimum_required(VERSION 3.13)
|
||||
|
||||
# Define the library name here.
|
||||
project(rntester_appmodules)
|
||||
project(helloworld_appmodules)
|
||||
|
||||
# This file includes all the necessary to let you build your application with the New Architecture.
|
||||
include(${REACT_ANDROID_DIR}/cmake-utils/ReactNative-application.cmake)
|
||||
|
||||
Reference in New Issue
Block a user