Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Look up HostObject computed properties on the right object in the prototype chain.

Browse Source 
Summary:
The change in the hermes repository fixes the security vulnerability
CVE-2020-1911.  This vulnerability only affects applications which
allow evaluation of uncontrolled, untrusted JavaScript code not
shipped with the app, so React Native apps will generally not be affected.

This revision includes a test for the bug.  The test is generic JSI
code, so it is included in the hermes and react-native repositories.

Changelog: [Internal]

Reviewed By: tmikov

Differential Revision: D23322992 (https://github.com/facebook/react-native/commit/0dee0e60366645c962848a73bbaf0fc7c49912d0)

fbshipit-source-id: 4e88c974afe1ad33a263f9cac03e9dc98d33649a
This commit is contained in:
Marc Horowitz
2020-08-26 11:30:34 -07:00
committed by Jon Janzen
parent 1270873ed6
commit 525e55f898
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/jsi/test/testlib.cpp
+17
View File
@@ -394,6 +394,23 @@ TEST_P(JSITest, HostObjectTest) {
.getBool());
}
TEST_P(JSITest, HostObjectProtoTest) {
class ProtoHostObject : public HostObject {
Value get(Runtime& rt, const PropNameID&) override {
return String::createFromAscii(rt, "phoprop");
}
};
rt.global().setProperty(
rt,
"pho",
Object::createFromHostObject(rt, std::make_shared<ProtoHostObject>()));
EXPECT_EQ(
eval("({__proto__: pho})[Symbol.toPrimitive]").getString(rt).utf8(rt),
"phoprop");
}
TEST_P(JSITest, ArrayTest) {
eval("x = {1:2, '3':4, 5:'six', 'seven':['eight', 'nine']}");