mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Disable native source code fetching in jsinspector-modern targets (#46132)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46132 Temporaily disable the `nativeSourceCodeFetching` capability — which reverts this to the legacy handling in the Inspector Proxy. This is because we've noticed performance issues when loading large bundle source maps, particularly on Android, with a nontrivial path to optimising this ([raising the frontend `IO.read` size](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/pull/97) further is leading to WebSocket disconnections on Android 😐). Changelog: [Internal] Reviewed By: robhogan Differential Revision: D61543480 fbshipit-source-id: ee66b4cebd40f8cc6466270c5875df744d2b588a
This commit is contained in:
committed by
Facebook GitHub Bot
parent
a462dfd6ce
commit
516428771d
@@ -483,7 +483,7 @@ RCT_NOT_IMPLEMENTED(-(instancetype)init)
|
||||
}
|
||||
return strongSelf->_inspectorTarget->connect(std::move(remote));
|
||||
},
|
||||
{.nativePageReloads = true, .nativeSourceCodeFetching = true, .prefersFuseboxFrontend = true});
|
||||
{.nativePageReloads = true, .prefersFuseboxFrontend = true});
|
||||
}
|
||||
|
||||
Class bridgeClass = self.bridgeClass;
|
||||
|
||||
+1
-3
@@ -79,9 +79,7 @@ ReactInstanceManagerInspectorTarget::ReactInstanceManagerInspectorTarget(
|
||||
-> std::unique_ptr<ILocalConnection> {
|
||||
return inspectorTarget->connect(std::move(remote));
|
||||
},
|
||||
{.nativePageReloads = true,
|
||||
.nativeSourceCodeFetching = true,
|
||||
.prefersFuseboxFrontend = true});
|
||||
{.nativePageReloads = true, .prefersFuseboxFrontend = true});
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
+1
-3
@@ -44,9 +44,7 @@ JReactHostInspectorTarget::JReactHostInspectorTarget(
|
||||
// Reject the connection.
|
||||
return nullptr;
|
||||
},
|
||||
{.nativePageReloads = true,
|
||||
.nativeSourceCodeFetching = true,
|
||||
.prefersFuseboxFrontend = true});
|
||||
{.nativePageReloads = true, .prefersFuseboxFrontend = true});
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -227,7 +227,7 @@ class RCTHostHostTargetDelegate : public facebook::react::jsinspector_modern::Ho
|
||||
}
|
||||
return strongSelf->_inspectorTarget->connect(std::move(remote));
|
||||
},
|
||||
{.nativePageReloads = true, .nativeSourceCodeFetching = true, .prefersFuseboxFrontend = true});
|
||||
{.nativePageReloads = true, .prefersFuseboxFrontend = true});
|
||||
}
|
||||
if (_instance) {
|
||||
RCTLogWarn(
|
||||
|
||||
Reference in New Issue
Block a user