Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: return nullptr when USE_THIRD_PARTY_JSC is set to true (#49781)

Browse Source 
Summary:
When setting `USE_THIRD_PARTY_JSC=1`, we don't return anything from createJSRuntimeFactory function:

![CleanShot 2025-03-03 at 13 05 24@2x](https://github.com/user-attachments/assets/090ca47a-77f8-4a1b-9171-79b5e4ce91fb)

It's meant to be overwritten, but we must satisfy the compiler.

## Changelog:

[IOS] [FIXED] - return nullptr when USE_THIRD_PARTY_JSC is set to true

Pull Request resolved: https://github.com/facebook/react-native/pull/49781

Test Plan: CI Green

Reviewed By: cortinico

Differential Revision: D70486837

Pulled By: cipolleschi

fbshipit-source-id: c09622f75608dc203d41167fc375a000a2f12e37
This commit is contained in:
Oskar Kwaśniewski
2025-03-03 06:01:23 -08:00
committed by Facebook GitHub Bot
parent 6bc5ddea3e
commit 515ff1e626
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm
+2
View File
@@ -49,6 +49,8 @@
return jsrt_create_hermes_factory();
#elif USE_THIRD_PARTY_JSC != 1
return jsrt_create_jsc_factory();
#else
return nullptr;
#endif
}