Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary deallocator in RCTSliderComponentView

Browse Source 
Summary:
Changelog: [Internal]

There is no need for custom dealloc, let's get rid of it.
We also prefer east const over west const.

Reviewed By: shergin

Differential Revision: D21997545

fbshipit-source-id: aa017f99aa26421fc59b353d0012687cb38fac08
This commit is contained in:
Samuel Susla authored and Facebook GitHub Bot committed 2020-06-11 09:44:21 -07:00
1 parent 2290751ac9
commit 4feb5b7ffd
1 file changed
+4 -12
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/Slider/RCTSliderComponentView.mm
+4 -12
View File
@@ -29,10 +29,10 @@ using namespace facebook::react;
UIImage *_maximumTrackImage;
UIImage *_thumbImage;
const ImageResponseObserverCoordinator *_trackImageCoordinator;
const ImageResponseObserverCoordinator *_minimumTrackImageCoordinator;
const ImageResponseObserverCoordinator *_maximumTrackImageCoordinator;
const ImageResponseObserverCoordinator *_thumbImageCoordinator;
ImageResponseObserverCoordinator const *_trackImageCoordinator;
ImageResponseObserverCoordinator const *_minimumTrackImageCoordinator;
ImageResponseObserverCoordinator const *_maximumTrackImageCoordinator;
ImageResponseObserverCoordinator const *_thumbImageCoordinator;
RCTImageResponseObserverProxy _trackImageResponseObserverProxy;
RCTImageResponseObserverProxy _minimumTrackImageResponseObserverProxy;
@@ -96,14 +96,6 @@ using namespace facebook::react;
_previousValue = props.value;
}
- (void)dealloc
{
self.trackImageCoordinator = nullptr;
self.minimumTrackImageCoordinator = nullptr;
self.maximumTrackImageCoordinator = nullptr;
self.thumbImageCoordinator = nullptr;
}
#pragma mark - RCTComponentViewProtocol
+ (ComponentDescriptorProvider)componentDescriptorProvider