mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
rntester Android > Don't call rncore_ModuleProvider(name, params) twice (#40758)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/40758 This is a follow up to https://github.com/facebook/react-native/pull/39987?fbclid=IwAR3qXLYUtfGSg81CpfDZFAwlnOb2J0zcJb1Wpc9ikLtd_9w2FUDovD6Xwx8 As we already call ``` return rncore_ModuleProvider(name, params); ``` in: https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultTurboModuleManagerDelegate.cpp#L55 we don't have to do it again in: https://github.com/facebook/react-native/blob/main/packages/rn-tester/android/app/src/main/jni/OnLoad.cpp#L53 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D50109991 fbshipit-source-id: eeb5af739f4dbf4bf45a21a13eec44ae772db7c4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
9e3d466c48
commit
4e92f609af
@@ -14,7 +14,6 @@
|
||||
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
|
||||
#include <react/renderer/components/AppSpecs/ComponentDescriptors.h>
|
||||
#include <react/renderer/components/legacyviewmanagerinterop/UnstableLegacyViewManagerInteropComponentDescriptor.h>
|
||||
#include <rncore.h>
|
||||
|
||||
namespace facebook {
|
||||
namespace react {
|
||||
@@ -50,7 +49,7 @@ std::shared_ptr<TurboModule> javaModuleProvider(
|
||||
if (module != nullptr) {
|
||||
return module;
|
||||
};
|
||||
return rncore_ModuleProvider(name, params);
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
} // namespace react
|
||||
|
||||
Reference in New Issue
Block a user