Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix reatain cycle RCTPullToRefreshViewComponentView <-> RCTScrollViewComponentView

Browse Source 
Summary:
Changelog: [iOS][Fixed] - `_scrollViewComponentView` is set to `RCTPullToRefreshViewComponentView's` superview:
```
_scrollViewComponentView = [RCTScrollViewComponentView findScrollViewComponentViewForView:self];
```
It should be safe to make it weak.

Reviewed By: javache

Differential Revision: D36998626

fbshipit-source-id: 2130b743d181e15986cb68636d60507a986968e1
This commit is contained in:
Dmitry Rykun
2022-06-09 02:39:54 -07:00
committed by Facebook GitHub Bot
parent 68e4e91bd4
commit 4e4b9e2111
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm
+1 -1
View File
@@ -25,7 +25,7 @@ using namespace facebook::react;
@implementation RCTPullToRefreshViewComponentView {
UIRefreshControl *_refreshControl;
RCTScrollViewComponentView *_scrollViewComponentView;
RCTScrollViewComponentView *__weak _scrollViewComponentView;
}
- (instancetype)initWithFrame:(CGRect)frame