Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support HermesAPILeanOrFull in react native apps (#36202)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36202

This changes all of the in-built dependencies in react native app components upon hermes from HermesAPI to HermesAPIFullOrLean.

HermesAPI (full) includes the bytecode compiler and thus has support for eval().
HermesAPILean does not include the bytecode compiler. It throws at runtime if eval is called. The native dependencies are significantly smaller without the bytecode compiler.

The HermesAPIFullOrLean target toggles between full and lean modes based on the value of buckconfig field `hermes.lean_vm` (default is false). Therefore, without overriding this config option, this change is a no-op and should result in react native apps being built with exactly the same dependencies as before.

If you do specify it, you lose eval support at runtime and gain an apk size savings of a few hundred kB after compression.

This also removes the vestigial `hermes_api_dep()` build macro.

skip-frl-buck-targeting

Reviewed By: javache

Differential Revision: D43283200

fbshipit-source-id: 0157be4a9339f70e73d29d694c18b31805107000
This commit is contained in:
Ryan Schoppmeyer
2023-03-07 06:33:14 -08:00
committed by Facebook GitHub Bot
parent 419025df22
commit 4a925c43c2
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/jni/react/hermes/instrumentation/BUCK
+1 -1
View File
@@ -22,6 +22,6 @@ rn_xplat_cxx_library(
deps = [
react_native_target("jni/react/jni:jni"),
FBJNI_TARGET,
react_native_xplat_dep("hermes/API:HermesAPI"),
react_native_xplat_dep("hermes/API:HermesAPIFullOrLean"),
],
)
ReactCommon/hermes/inspector/BUCK
+3 -3
View File
@@ -62,7 +62,7 @@ fb_xplat_cxx_library(
":inspectorlib",
"//third-party/glog:glog",
"//xplat/folly:futures",
"//xplat/hermes/API:HermesAPI",
"//xplat/hermes/API:HermesAPIFullOrLean",
"//xplat/jsi:JSIDynamic",
"//xplat/jsi:jsi",
],
@@ -164,7 +164,7 @@ fb_xplat_cxx_binary(
deps = [
":chrome",
":inspectorlib",
"//xplat/hermes/API:HermesAPI",
"//xplat/hermes/API:HermesAPIFullOrLean",
],
)
@@ -203,7 +203,7 @@ fb_xplat_cxx_library(
":detail",
"//third-party/glog:glog",
"//xplat/folly:futures",
"//xplat/hermes/API:HermesAPI",
"//xplat/hermes/API:HermesAPIFullOrLean",
"//xplat/jsi:jsi",
],
)