hadle nullable params in generated objcpp

Summary: Param of function can be optional and it should have impact on native code. Inspired by old codegen

Reviewed By: RSNara

Differential Revision: D16763884

fbshipit-source-id: dab50275f902dbe4af25824bb6128d3b37fc43cd

packages/react-native-codegen/e2e/__test_fixtures__/modules/NativeNullableTurboModule.js

@@ -14,11 +14,11 @@ import type {TurboModule} from 'react-native/Libraries/TurboModule/RCTExport';
 import * as TurboModuleRegistry from 'react-native/Libraries/TurboModule/TurboModuleRegistry';
 
 export interface Spec extends TurboModule {
-  +getBool: () => ?boolean;
-  +getNumber: () => ?number;
-  +getString: () => ?string;
-  +getArray: () => ?Array<any>;
-  +getObject: () => ?Object;
+  +getBool: (a: ?boolean) => ?boolean;
+  +getNumber: (a: ?number) => ?number;
+  +getString: (a: ?number) => ?string;
+  +getArray: (a: ?Array<any>) => ?Array<any>;
+  +getObject: (a: ?Object) => ?Object;
   +getValueWithPromise: () => ?Promise<string>;
 }
 

packages/react-native-codegen/src/generators/modules/GenerateModuleHObjCpp.js

@@ -12,7 +12,7 @@
 
 import type {
   SchemaType,
-  FunctionTypeAnnotationParamTypeAnnotation,
+  FunctionTypeAnnotationParam,
   FunctionTypeAnnotationReturn,
   ObjectParamTypeAnnotation,
 } from '../../CodegenSchema';
@@ -91,26 +91,29 @@ const constants = `- (facebook::react::ModuleConstants<JS::Native::_MODULE_NAME_
 - (facebook::react::ModuleConstants<JS::Native::_MODULE_NAME_::::Constants::Builder>)getConstants;`;
 
 function translatePrimitiveJSTypeToObjCType(
-  type: FunctionTypeAnnotationParamTypeAnnotation,
+  param: FunctionTypeAnnotationParam,
   error: string,
 ) {
-  switch (type.type) {
+  function wrapIntoNullableIfNeeded(generatedType: string) {
+    return param.nullable ? `${generatedType} _Nullable` : generatedType;
+  }
+  switch (param.typeAnnotation.type) {
     case 'StringTypeAnnotation':
-      return 'NSString *';
+      return wrapIntoNullableIfNeeded('NSString *');
     case 'NumberTypeAnnotation':
     case 'FloatTypeAnnotation':
     case 'Int32TypeAnnotation':
-      return 'NSNumber *';
+      return param.nullable ? 'NSNumber *' : 'double';
     case 'BooleanTypeAnnotation':
-      return 'BOOL';
+      return param.nullable ? 'NSNumber * _Nullable' : 'BOOL';
     case 'GenericObjectTypeAnnotation':
-      return 'NSDictionary *';
+      return wrapIntoNullableIfNeeded('NSDictionary *');
     case 'ArrayTypeAnnotation':
-      return 'NSArray<id<NSObject>> *';
+      return wrapIntoNullableIfNeeded('NSArray *');
     case 'FunctionTypeAnnotation':
       return 'RCTResponseSenderBlock';
     case 'ObjectTypeAnnotation':
-      return 'NSDictionary *';
+      return wrapIntoNullableIfNeeded('NSDictionary *');
     default:
       throw new Error(error);
   }
@@ -193,7 +196,7 @@ module.exports = {
                   });
                 }
                 const paramObjCType = translatePrimitiveJSTypeToObjCType(
-                  param.typeAnnotation,
+                  param,
                   `Unspopported type for param "${param.name}" in ${
                     prop.name
                   }. Found: ${param.typeAnnotation.type}`,

packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleHObjCpp-test.js.snap

@@ -294,11 +294,11 @@ inline JS::NativeSampleTurboModule::Constants::Builder::Builder(Constants i) : _
 - (facebook::react::ModuleConstants<JS::NativeSampleTurboModule::Constants::Builder>)getConstants;
 - (void) voidFunc;
 - (BOOL) getBool:(BOOL)arg;
-- (NSNumber *) getNumber:(NSNumber *)arg;
+- (NSNumber *) getNumber:(double)arg;
 - (NSString *) getString:(NSString *)arg;
-- (NSArray<id<NSObject>> *) getArray:(NSArray<id<NSObject>> *)arg;
+- (NSArray<id<NSObject>> *) getArray:(NSArray *)arg;
 - (NSDictionary *) getObject:(NSDictionary *)arg;
-- (NSDictionary *) getValue:(NSNumber *)x
+- (NSDictionary *) getValue:(double)x
    y:(NSString *)y
    z:(NSDictionary *)z;
 - (void) getValueWithCallback:(RCTResponseSenderBlock)callback;