mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover react/renderer/telemetry with guards (#58301)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58301 Classifies `react/renderer/telemetry:telemetry` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/FrameworksGuard.h>` to the module's 2 non-test headers, and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D118612692 fbshipit-source-id: ef8f9ab90699f272d0592d56dd68550ae3b6f84f
This commit is contained in:
1 parent
d9ad3f0b2f
commit
477e14af1b
3 files changed
+5
No files matched your search
@@ -17,6 +17,7 @@ target_link_libraries(react_renderer_telemetry
|
||||
folly_runtime
|
||||
glog
|
||||
glog_init
|
||||
react_cxxstableapi
|
||||
react_debug
|
||||
react_renderer_core
|
||||
react_renderer_debug
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <vector>
|
||||
|
||||
#include <react/renderer/telemetry/TransactionTelemetry.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <chrono>
|
||||
#include <cstdint>
|
||||
#include <functional>
|
||||
|
||||
Reference in new issue
Block a user