Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply Nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java (#50358)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50358

Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D71979595

fbshipit-source-id: 19bfcea537b7b62536eafa8e1d0b3f8b50666e22
This commit is contained in:
Gijs Weterings
2025-04-07 06:33:09 -07:00
committed by Facebook GitHub Bot
parent 90184d20e1
commit 4664db138f
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/turbomodule/core/TurboModuleManager.java
+7
View File
@@ -67,12 +67,14 @@ public class TurboModuleManager implements TurboModuleRegistry {
@Nullable final TurboModuleManagerDelegate delegate,
CallInvokerHolder jsCallInvokerHolder,
NativeMethodCallInvokerHolder nativeMethodCallInvokerHolder) {
// NULLSAFE_FIXME[Field Not Nullable]
mDelegate = delegate;
mHybridData =
initHybrid(
runtimeExecutor,
(CallInvokerHolderImpl) jsCallInvokerHolder,
(NativeMethodCallInvokerHolderImpl) nativeMethodCallInvokerHolder,
// NULLSAFE_FIXME[Parameter Not Nullable]
delegate);
installJSIBindings(shouldEnableLegacyModuleInterop());
@@ -240,12 +242,16 @@ public class TurboModuleManager implements TurboModuleRegistry {
moduleHolder = mModuleHolders.get(moduleName);
}
// NULLSAFE_FIXME[Nullable Dereference]
TurboModulePerfLogger.moduleCreateStart(moduleName, moduleHolder.getModuleId());
// NULLSAFE_FIXME[Parameter Not Nullable]
NativeModule module = getOrCreateModule(moduleName, moduleHolder, true);
if (module != null) {
// NULLSAFE_FIXME[Nullable Dereference]
TurboModulePerfLogger.moduleCreateEnd(moduleName, moduleHolder.getModuleId());
} else {
// NULLSAFE_FIXME[Nullable Dereference]
TurboModulePerfLogger.moduleCreateFail(moduleName, moduleHolder.getModuleId());
}
@@ -426,6 +432,7 @@ public class TurboModuleManager implements TurboModuleRegistry {
}
private static class ModuleHolder {
// NULLSAFE_FIXME[Field Not Nullable]
private volatile NativeModule mModule = null;
private volatile boolean mIsTryingToCreate = false;
private volatile boolean mIsDoneCreatingModule = false;