Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

add feature flag to disable Choreographer callbacks in Paper infra

Browse Source 
Summary:
changelog: [internal]

For constrained environments, we want to lower cpu usage of RN when the app is idle. `UIViewOperationQueue` and `EventDispatcherImpl` are not used in Fabric and therefore they do not need to run on each frame.

Reviewed By: javache

Differential Revision: D50741161

fbshipit-source-id: aa605893f1c8a4ac97a49bb7a6de2e2637a0832e
This commit is contained in:
Samuel Susla
2023-10-30 07:42:24 -07:00
committed by Facebook GitHub Bot
parent e2eb26c951
commit 4655f2063d
3 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
+8
View File
@@ -174,4 +174,12 @@ public class ReactFeatureFlags {
* in JS will be rejected (The JS error will include native stack)
*/
public static boolean rejectTurboModulePromiseOnNativeError = true;
/*
* When the app is completely migrated to Fabric, set this flag to true to
* disable parts of Paper infrastructre that are not needed anymore but consume
* memory and CPU. Specifically, UIViewOperationQueue and EventDispatcherImpl will no
* longer work as they won't subscribe to ReactChoregrapher for updates.
*/
public static boolean enableFabricRendererExclusively = false;
}
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java
+5 -2
View File
@@ -25,6 +25,7 @@ import com.facebook.react.bridge.RetryableMountingLayerException;
import com.facebook.react.bridge.SoftAssertions;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.common.ReactConstants;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.modules.core.ReactChoreographer;
import com.facebook.react.uimanager.debug.NotThreadSafeViewHierarchyUpdateDebugListener;
import com.facebook.systrace.Systrace;
@@ -962,8 +963,10 @@ public class UIViewOperationQueue {
/* package */ void resumeFrameCallback() {
mIsDispatchUIFrameCallbackEnqueued = true;
ReactChoreographer.getInstance()
.postFrameCallback(ReactChoreographer.CallbackType.DISPATCH_UI, mDispatchUIFrameCallback);
if (!ReactFeatureFlags.enableFabricRendererExclusively) {
ReactChoreographer.getInstance()
.postFrameCallback(ReactChoreographer.CallbackType.DISPATCH_UI, mDispatchUIFrameCallback);
}
}
/* package */ void pauseFrameCallback() {
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/EventDispatcherImpl.java
+6 -2
View File
@@ -14,6 +14,7 @@ import com.facebook.react.bridge.LifecycleEventListener;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.common.MapBuilder;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.modules.core.ReactChoreographer;
import com.facebook.react.uimanager.common.UIManagerType;
import com.facebook.systrace.Systrace;
@@ -315,8 +316,11 @@ public class EventDispatcherImpl implements EventDispatcher, LifecycleEventListe
}
private void post() {
ReactChoreographer.getInstance()
.postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, mCurrentFrameCallback);
if (!ReactFeatureFlags.enableFabricRendererExclusively) {
ReactChoreographer.getInstance()
.postFrameCallback(
ReactChoreographer.CallbackType.TIMERS_EVENTS, mCurrentFrameCallback);
}
}
public void maybePostFromNonUI() {