Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor hasComponent binding so it uses bridging API (#37150)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/37150

This diff should simplify binding of `__nativeComponentRegistry__hasComponent`.

Changelog: [Internal] - Simplify `hasComponent` binding by using bridging API.

Reviewed By: javache

Differential Revision: D45150027

fbshipit-source-id: 6d7ee09af3d4d64392f5ddf0f4cf46d77d3fc878
This commit is contained in:
Dmitry Rykun
2023-05-02 04:36:54 -07:00
committed by Facebook GitHub Bot
parent 76a42c292d
commit 4568e8f477
4 changed files with 13 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm
+1 -1
View File
@@ -49,7 +49,7 @@ void RCTInstallNativeComponentRegistryBinding(facebook::jsi::Runtime &runtime)
return [[RCTComponentViewFactory currentComponentViewFactory]
registerComponentIfPossible:componentNameByReactViewName(name)];
};
NativeComponentRegistryBinding::install(runtime, std::move(hasComponentProvider));
bindHasComponentProvider(runtime, std::move(hasComponentProvider));
}
static Class<RCTComponentViewProtocol> RCTComponentViewClassWithName(const char *componentName)
packages/react-native/ReactAndroid/src/main/jni/react/uimanager/ComponentNameResolverManager.cpp
+1 -2
View File
@@ -67,8 +67,7 @@ void ComponentNameResolverManager::installJSIBindings() {
return thizz->componentNames_.find(name) != thizz->componentNames_.end();
};
react::NativeComponentRegistryBinding::install(
runtime, std::move(viewManagerProvider));
bindHasComponentProvider(runtime, std::move(viewManagerProvider));
});
}
packages/react-native/ReactCommon/react/renderer/componentregistry/native/NativeComponentRegistryBinding.cpp
+5 -43
View File
@@ -7,60 +7,22 @@
#include "NativeComponentRegistryBinding.h"
#include <react/bridging/Bridging.h>
#include <stdexcept>
#include <string>
using namespace facebook;
namespace facebook::react {
/**
* Public API to install the NativeComponentRegistryBinding.
* Public API to install the Native Component Registry bindings.
*/
NativeComponentRegistryBinding::NativeComponentRegistryBinding(
const HasComponentProviderFunctionType &&hasComponentProvider)
: hasComponentProvider_(hasComponentProvider) {}
void NativeComponentRegistryBinding::install(
void bindHasComponentProvider(
jsi::Runtime &runtime,
const HasComponentProviderFunctionType &&hasComponentProvider) {
HasComponentProviderFunctionType &&provider) {
runtime.global().setProperty(
runtime,
"__nativeComponentRegistry__hasComponent",
jsi::Function::createFromHostFunction(
runtime,
jsi::PropNameID::forAscii(
runtime, "__nativeComponentRegistry__hasComponent"),
1,
[binding = std::make_shared<NativeComponentRegistryBinding>(
std::move(hasComponentProvider))](
jsi::Runtime &rt,
const jsi::Value &thisVal,
const jsi::Value *args,
size_t count) {
return binding->jsProxy(rt, thisVal, args, count);
}));
}
bool NativeComponentRegistryBinding::hasComponent(const std::string &name) {
return hasComponentProvider_(name);
}
jsi::Value NativeComponentRegistryBinding::jsProxy(
jsi::Runtime &runtime,
const jsi::Value & /*thisVal*/,
const jsi::Value *args,
size_t count) {
if (count != 1) {
throw std::invalid_argument(
"__nativeComponentRegistry__hasComponent must be called with 1 argument");
}
std::string moduleName = args[0].getString(runtime).utf8(runtime);
jsi::Value nullSchema = jsi::Value::undefined();
bool result = hasComponent(moduleName);
return {result};
bridging::toJs(runtime, provider, {}));
}
} // namespace facebook::react
packages/react-native/ReactCommon/react/renderer/componentregistry/native/NativeComponentRegistryBinding.h
+6 -34
View File
@@ -20,40 +20,12 @@ namespace facebook::react {
using HasComponentProviderFunctionType =
std::function<bool(const std::string &name)>;
/**
* Represents the JavaScript binding for the HasComponent global function.
/*
* Installs HasComponentProviderFunction into JavaScript runtime.
* Thread synchronization must be enforced externally.
*/
class NativeComponentRegistryBinding {
public:
/*
* Installs NativeComponentRegistryBinding into JavaScript runtime.
* Thread synchronization must be enforced externally.
*/
static void install(
jsi::Runtime &runtime,
const HasComponentProviderFunctionType &&provider);
NativeComponentRegistryBinding(
const HasComponentProviderFunctionType &&provider);
/**
* Returns if there's a component registered with the name received as a
* parameter
*/
bool hasComponent(const std::string &name);
private:
/**
* A lookup function exposed to JS to determine if a component is registered
* in the native platform.
*/
jsi::Value jsProxy(
jsi::Runtime &runtime,
const jsi::Value &thisVal,
const jsi::Value *args,
size_t count);
HasComponentProviderFunctionType hasComponentProvider_;
};
void bindHasComponentProvider(
jsi::Runtime &runtime,
HasComponentProviderFunctionType &&provider);
} // namespace facebook::react