Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect comment about strictEquals

Browse Source 
Summary:
The documentation of jsi::Value::strictEquals was confusing it with SameValue (which differs in treatment of signed zeroes and NaN). Fix it by referring to the correct part of the spec.

Changelog:
[Internal][Fixed] - Fix incorrect comment

Reviewed By: avp

Differential Revision: D26430216

fbshipit-source-id: 0ea4208fbdda40c87f8028231ddefb2323b6eb96
This commit is contained in:
Daniel Andersson
2021-03-10 15:33:31 -08:00
committed by Facebook GitHub Bot
parent 2b2c69aab1
commit 42fa4a6a4e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/jsi/jsi/jsi.h
+2 -2
View File
@@ -995,8 +995,8 @@ class JSI_EXPORT Value {
return runtime.createValueFromJsonUtf8(json, length);
}
/// \return according to the SameValue algorithm see more here:
// https://www.ecma-international.org/ecma-262/5.1/#sec-11.9.4
/// \return according to the Strict Equality Comparison algorithm, see:
/// https://262.ecma-international.org/11.0/#sec-strict-equality-comparison
static bool strictEquals(Runtime& runtime, const Value& a, const Value& b);
Value& operator=(Value&& other) {