Fix Yoga Style equality crash for size-typed dimensions (#56429)

Summary:
X-link: https://github.com/facebook/yoga/pull/1931

Pull Request resolved: https://github.com/facebook/react-native/pull/56429

Changelog: [Internal]

The existing `lengthsEqual` comparator was used for `dimensions_`, `minDimensions_`, and `maxDimensions_`, but these are size-typed values stored via `StyleValuePool::getSize()`, not length-typed. Using the wrong accessor caused crashes during style equality checks.

Added a `sizeLengthsEqual` helper (scalar + array overloads) that correctly calls `StyleValuePool::getSize()` and swapped it in for the three dimension fields in `Style::operator==`.

Reviewed By: joevilches

Differential Revision: D100189121

fbshipit-source-id: 284f849d01ca7d15ca34d2dcaafaa92ee9dfd59f
This commit is contained in:
Devan Buggay authored and meta-codesync[bot] committed 2026-04-14 08:29:35 -07:00
1 parent 8550370136
commit 40c7d8f6f0
1 file changed
+28 -3
@@ -661,10 +661,10 @@ class YG_EXPORT Style {
lengthsEqual(padding_, pool_, other.padding_, other.pool_) &&
lengthsEqual(border_, pool_, other.border_, other.pool_) &&
lengthsEqual(gap_, pool_, other.gap_, other.pool_) &&
lengthsEqual(dimensions_, pool_, other.dimensions_, other.pool_) &&
lengthsEqual(
sizeLengthsEqual(dimensions_, pool_, other.dimensions_, other.pool_) &&
sizeLengthsEqual(
minDimensions_, pool_, other.minDimensions_, other.pool_) &&
lengthsEqual(
sizeLengthsEqual(
maxDimensions_, pool_, other.maxDimensions_, other.pool_) &&
numbersEqual(aspectRatio_, pool_, other.aspectRatio_, other.pool_) &&
gridTemplateColumns_ == other.gridTemplateColumns_ &&
@@ -716,6 +716,31 @@ class YG_EXPORT Style {
});
}
static inline bool sizeLengthsEqual(
const StyleValueHandle& lhsHandle,
const StyleValuePool& lhsPool,
const StyleValueHandle& rhsHandle,
const StyleValuePool& rhsPool) {
return (lhsHandle.isUndefined() && rhsHandle.isUndefined()) ||
(lhsPool.getSize(lhsHandle) == rhsPool.getSize(rhsHandle));
}
template <size_t N>
static inline bool sizeLengthsEqual(
const std::array<StyleValueHandle, N>& lhs,
const StyleValuePool& lhsPool,
const std::array<StyleValueHandle, N>& rhs,
const StyleValuePool& rhsPool) {
return std::equal(
lhs.begin(),
lhs.end(),
rhs.begin(),
rhs.end(),
[&](const auto& lhs, const auto& rhs) {
return sizeLengthsEqual(lhs, lhsPool, rhs, rhsPool);
});
}
StyleValueHandle computeColumnGap() const {
if (gap_[yoga::to_underlying(Gutter::Column)].isDefined()) {
return gap_[yoga::to_underlying(Gutter::Column)];