mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Downgrade fatal error in FabricMountingManager (#47329)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47329 Downgrading from fatal (introduced in D63148523). It's not yet clear why this is firing, and may point at deeper underlying issues, as the re-ordering we do in `disableMountItemReorderingAndroid` only occurs at a later point in `FabricMountingManager`. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D65267936 fbshipit-source-id: cb32b149a77c9e5a3ac6350baaeae9c7215df01b
This commit is contained in:
1 parent
667ba76aef
commit
3e46cb384c
1 file changed
+5
-4
+5
-4
@@ -495,7 +495,8 @@ void FabricMountingManager::executeMount(
|
||||
? allocatedViewsIterator->second
|
||||
: defaultAllocatedViews;
|
||||
if (allocatedViewsIterator == allocatedViewRegistry_.end()) {
|
||||
LOG(ERROR) << "Executing commit after surface was stopped!";
|
||||
LOG(ERROR) << "Executing commit after surface " << surfaceId
|
||||
<< " was stopped!";
|
||||
}
|
||||
|
||||
for (const auto& mutation : mutations) {
|
||||
@@ -529,7 +530,7 @@ void FabricMountingManager::executeMount(
|
||||
(maintainMutationOrder ? cppCommonMountItems : cppDeleteMountItems)
|
||||
.push_back(CppMountItem::DeleteMountItem(oldChildShadowView));
|
||||
if (allocatedViewTags.erase(oldChildShadowView.tag) != 1) {
|
||||
LOG(ERROR) << "Emitting delete for unallocated view. "
|
||||
LOG(ERROR) << "Emitting delete for unallocated view "
|
||||
<< oldChildShadowView.tag;
|
||||
}
|
||||
break;
|
||||
@@ -537,7 +538,7 @@ void FabricMountingManager::executeMount(
|
||||
case ShadowViewMutation::Update: {
|
||||
if (!isVirtual) {
|
||||
if (!allocatedViewTags.contains(newChildShadowView.tag)) {
|
||||
LOG(FATAL) << "Emitting update for unallocated view. "
|
||||
LOG(ERROR) << "Emitting update for unallocated view "
|
||||
<< newChildShadowView.tag;
|
||||
}
|
||||
|
||||
@@ -605,7 +606,7 @@ void FabricMountingManager::executeMount(
|
||||
bool shouldCreateView =
|
||||
!allocatedViewTags.contains(newChildShadowView.tag);
|
||||
if (shouldCreateView) {
|
||||
LOG(ERROR) << "Emitting insert for unallocated view. "
|
||||
LOG(ERROR) << "Emitting insert for unallocated view "
|
||||
<< newChildShadowView.tag;
|
||||
(maintainMutationOrder ? cppCommonMountItems
|
||||
: cppUpdatePropsMountItems)
|
||||
|
||||
Reference in new issue
Block a user