Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove need for platform overrides to Settings (#38607)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38607

Today, any host platform implementation of React Native must add Settings.platform.js.

- https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Settings/Settings.windows.js

Now they don't have to do it anymore.

For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js

Changelog:
[General] [Fixed] - [Settings] Remove need for platform overrides to Settings

Reviewed By: rozele

Differential Revision: D47747018

fbshipit-source-id: 8e4e8d318b3285a9a64e0b4f052f721f6242f871
This commit is contained in:
Christoph Purrer
2023-07-25 15:04:31 -07:00
committed by Facebook GitHub Bot
parent 800ea60393
commit 3c15b68d56
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/Libraries/Settings/Settings.android.js → packages/react-native/Libraries/Settings/Settings.js
Vendored
+4 -4
View File
@@ -12,21 +12,21 @@
const Settings = {
get(key: string): mixed {
console.warn('Settings is not yet supported on Android');
console.warn('Settings is not yet supported on this platform.');
return null;
},
set(settings: Object) {
console.warn('Settings is not yet supported on Android');
console.warn('Settings is not yet supported on this platform.');
},
watchKeys(keys: string | Array<string>, callback: Function): number {
console.warn('Settings is not yet supported on Android');
console.warn('Settings is not yet supported on this platform.');
return -1;
},
clearWatch(watchId: number) {
console.warn('Settings is not yet supported on Android');
console.warn('Settings is not yet supported on this platform.');
},
};