mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Seal renderer View public boundary (#58787)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58787 Reclassify the CSS-dependent View conversion headers as private implementation details: - `BackgroundImagePropsConversions.h` - `BoxShadowPropsConversions.h` - `CSSConversions.h` - `FilterPropsConversions.h` - `propsConversions.h` These headers now use the private guard and are removed from the `<React/View.h>` umbrella, along with `conversions.h`. The public `accessibilityPropsConversions.h` stays in the umbrella: it is CSS-free, and framework-tier headers such as the attributed string conversions reach the accessibility role parsers through it. `LayoutConformanceProps.h` now includes the public `conversions.h` and core `propsConversions.h` instead of the private View `propsConversions.h`, so the umbrella stays self-contained under the strict API. Following the Graphics module, renderer CSS becomes an implementation dependency of View in Buck instead of an exported one. Header publishing in Buck, CocoaPods, SwiftPM, and Gradle prefab is unchanged, consistent with other private headers, and the C++ API snapshots are unchanged. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D119970889 fbshipit-source-id: f96854fbe991ef93d4065ffc411457f8622e23f6
This commit is contained in:
1 parent
791835efc6
commit
3928a43d8e
7 files changed
+7
-12
No files matched your search
+1
-1
@@ -7,7 +7,7 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <react/featureflags/ReactNativePublicFeatureFlags.h>
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
|
||||
+1
-1
@@ -7,7 +7,7 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <react/renderer/core/RawValue.h>
|
||||
|
||||
@@ -7,7 +7,7 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <react/renderer/core/RawValue.h>
|
||||
|
||||
+1
-1
@@ -7,7 +7,7 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
#include <react/renderer/core/RawValue.h>
|
||||
|
||||
+2
-1
@@ -10,7 +10,8 @@
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
|
||||
#include <react/renderer/components/view/YogaStylableProps.h>
|
||||
#include <react/renderer/components/view/propsConversions.h>
|
||||
#include <react/renderer/components/view/conversions.h>
|
||||
#include <react/renderer/core/propsConversions.h>
|
||||
|
||||
namespace facebook::react {
|
||||
|
||||
|
||||
@@ -33,14 +33,10 @@
|
||||
|
||||
#include <react/renderer/components/view/AccessibilityPrimitives.h>
|
||||
#include <react/renderer/components/view/AccessibilityProps.h>
|
||||
#include <react/renderer/components/view/BackgroundImagePropsConversions.h>
|
||||
#include <react/renderer/components/view/BaseTouch.h>
|
||||
#include <react/renderer/components/view/BaseViewEventEmitter.h>
|
||||
#include <react/renderer/components/view/BaseViewProps.h>
|
||||
#include <react/renderer/components/view/BoxShadowPropsConversions.h>
|
||||
#include <react/renderer/components/view/CSSConversions.h>
|
||||
#include <react/renderer/components/view/ConcreteViewShadowNode.h>
|
||||
#include <react/renderer/components/view/FilterPropsConversions.h>
|
||||
#include <react/renderer/components/view/HostPlatformTouch.h>
|
||||
#include <react/renderer/components/view/HostPlatformViewEventEmitter.h>
|
||||
#include <react/renderer/components/view/HostPlatformViewProps.h>
|
||||
@@ -60,9 +56,7 @@
|
||||
#include <react/renderer/components/view/YogaLayoutableShadowNode.h>
|
||||
#include <react/renderer/components/view/YogaStylableProps.h>
|
||||
#include <react/renderer/components/view/accessibilityPropsConversions.h>
|
||||
#include <react/renderer/components/view/conversions.h>
|
||||
#include <react/renderer/components/view/primitives.h>
|
||||
#include <react/renderer/components/view/propsConversions.h>
|
||||
|
||||
#undef RN_UMBRELLA_CONTEXT
|
||||
#pragma pop_macro("RN_UMBRELLA_CONTEXT")
|
||||
@@ -7,7 +7,7 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/UmbrellaGuard.h>
|
||||
#include <react/cxxstableapi/PrivateGuard.h>
|
||||
|
||||
#include <react/renderer/components/view/conversions.h>
|
||||
#include <react/renderer/core/PropsParserContext.h>
|
||||
|
||||
Reference in new issue
Block a user