mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix tests for JS codegen by renaming conflicting props
Summary:
** Summary of failures encountered during the build **
Rule //fbandroid/java/com/facebook/catalyst/launcher:app_prod_debug FAILED because Command failed with exit code 1.
stderr: /java/InterfaceOnlyNativeComponentViewManagerDelegate.java:18: error: reference to setAccessibilityHint is ambiguous
mViewManager.setAccessibilityHint(view, value == null ? "" : (String) value);
^
both method setAccessibilityHint(T,java.lang.String) in com.facebook.react.uimanager.BaseViewManagerInterface and method setAccessibilityHint(T,java.lang.String) in com.facebook.react.viewmanagers.InterfaceOnlyNativeComponentViewManagerInterface match
/java/StringPropNativeComponentViewManagerDelegate.java:18: error: reference to setAccessibilityHint is ambiguous
mViewManager.setAccessibilityHint(view, value == null ? "" : (String) value);
^
both method setAccessibilityHint(T,java.lang.String) in com.facebook.react.uimanager.BaseViewManagerInterface and method setAccessibilityHint(T,java.lang.String) in com.facebook.react.viewmanagers.StringPropNativeComponentViewManagerInterface match
/java/StringPropNativeComponentViewManagerDelegate.java:21: error: reference to setAccessibilityRole is ambiguous
mViewManager.setAccessibilityRole(view, value == null ? null : (String) value);
^
both method setAccessibilityRole(T,java.lang.String) in com.facebook.react.uimanager.BaseViewManagerInterface and method setAccessibilityRole(T,java.lang.String) in com.facebook.react.viewmanagers.StringPropNativeComponentViewManagerInterface match
Errors: 3. Warnings: 0.
When running <javac_jar>.
When building rule //xplat/js/react-native-github/packages/react-native-codegen:generated_components_java-codegen_testsAndroid.
```
Reviewed By: mdvacca
Differential Revision: D17107929
fbshipit-source-id: 32bc553d450628c530e22cb13f305e3a3e0f45cd
This commit is contained in:
committed by
Facebook Github Bot
parent
b31056d802
commit
38089753ef
+1
-1
@@ -26,5 +26,5 @@ public class InterfaceOnlyNativeComponentViewManager extends SimpleViewManager<V
|
||||
}
|
||||
|
||||
@Override
|
||||
public void setAccessibilityHint(ViewGroup view, String value) {}
|
||||
public void setTitle(ViewGroup view, String value) {}
|
||||
}
|
||||
|
||||
+2
-2
@@ -25,8 +25,8 @@ public class StringPropNativeComponentViewManager extends SimpleViewManager<View
|
||||
}
|
||||
|
||||
@Override
|
||||
public void setAccessibilityHint(ViewGroup view, String value) {}
|
||||
public void setPlaceholder(ViewGroup view, String value) {}
|
||||
|
||||
@Override
|
||||
public void setAccessibilityRole(ViewGroup view, String value) {}
|
||||
public void setDefaultValue(ViewGroup view, String value) {}
|
||||
}
|
||||
|
||||
Vendored
+1
-1
@@ -22,7 +22,7 @@ type NativeProps = $ReadOnly<{|
|
||||
...ViewProps,
|
||||
|
||||
// Props
|
||||
accessibilityHint?: WithDefault<string, ''>,
|
||||
title?: WithDefault<string, ''>,
|
||||
|
||||
// Events
|
||||
onChange?: ?BubblingEventHandler<$ReadOnly<{|value: boolean|}>>,
|
||||
|
||||
Vendored
+2
-2
@@ -19,8 +19,8 @@ type NativeProps = $ReadOnly<{|
|
||||
...ViewProps,
|
||||
|
||||
// Props
|
||||
accessibilityHint?: WithDefault<string, ''>,
|
||||
accessibilityRole?: string,
|
||||
placeholder?: WithDefault<string, ''>,
|
||||
defaultValue?: string,
|
||||
|}>;
|
||||
|
||||
export default (codegenNativeComponent<NativeProps>(
|
||||
|
||||
Reference in New Issue
Block a user