mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Delete getConstants from ImageEditingManager
Summary: `NativeImageEditor` doesn't export any constants. Therefore, `ImageEditingManager` doesn't need a `getConstants()` method. In a subsequent diff (D18888735), I rename all `ReactMethod getConstants()` methods to `Override getTypedExportedConstants()`. This raises an error because the spec for `ImageEditingManager` doesn't contain a `getTypedExportedConstants()` method. Changelog: [Internal] - Delete getConstants() from ImageEditingManager Reviewed By: fkgozali Differential Revision: D18909419 fbshipit-source-id: 7e4f84f102068aa44bb3d267c66a60c0d0d27404
This commit is contained in:
committed by
Facebook Github Bot
parent
b42371da5a
commit
37df2b28ad
@@ -42,9 +42,7 @@ import java.io.OutputStream;
|
||||
import java.net.URL;
|
||||
import java.net.URLConnection;
|
||||
import java.util.Arrays;
|
||||
import java.util.Collections;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
|
||||
/** Native module that provides image cropping functionality. */
|
||||
@ReactModule(name = ImageEditingManager.NAME)
|
||||
@@ -99,11 +97,6 @@ public class ImageEditingManager extends ReactContextBaseJavaModule {
|
||||
return NAME;
|
||||
}
|
||||
|
||||
@Override
|
||||
public Map<String, Object> getConstants() {
|
||||
return Collections.emptyMap();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onCatalystInstanceDestroy() {
|
||||
new CleanTask(getReactApplicationContext()).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
|
||||
|
||||
Reference in New Issue
Block a user