From 37df2b28ad8a3c698e67250c2464feba78f7832a Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Tue, 10 Dec 2019 12:32:28 -0800 Subject: [PATCH] Delete getConstants from ImageEditingManager Summary: `NativeImageEditor` doesn't export any constants. Therefore, `ImageEditingManager` doesn't need a `getConstants()` method. In a subsequent diff (D18888735), I rename all `ReactMethod getConstants()` methods to `Override getTypedExportedConstants()`. This raises an error because the spec for `ImageEditingManager` doesn't contain a `getTypedExportedConstants()` method. Changelog: [Internal] - Delete getConstants() from ImageEditingManager Reviewed By: fkgozali Differential Revision: D18909419 fbshipit-source-id: 7e4f84f102068aa44bb3d267c66a60c0d0d27404 --- .../facebook/react/modules/camera/ImageEditingManager.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageEditingManager.java b/ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageEditingManager.java index 87036200cd3..9bc82530d34 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageEditingManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/camera/ImageEditingManager.java @@ -42,9 +42,7 @@ import java.io.OutputStream; import java.net.URL; import java.net.URLConnection; import java.util.Arrays; -import java.util.Collections; import java.util.List; -import java.util.Map; /** Native module that provides image cropping functionality. */ @ReactModule(name = ImageEditingManager.NAME) @@ -99,11 +97,6 @@ public class ImageEditingManager extends ReactContextBaseJavaModule { return NAME; } - @Override - public Map getConstants() { - return Collections.emptyMap(); - } - @Override public void onCatalystInstanceDestroy() { new CleanTask(getReactApplicationContext()).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);