mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
ISerialization methods should take in const jsi::Value& (#56410)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56410 Missed when we first added the `ISerialization` interface. In JSI APIs, `Value` is generally passed in as a const reference. This makes it clear that the actual reference, not the referent, is const. Fixing the serialization methods to be consistent with the rest of JSI. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D100222030 fbshipit-source-id: 2297d5c89b90db51269d216e6c3a822d9a4a93ab
This commit is contained in:
1 parent
5087aa0dba
commit
36b30602d2
1 file changed
+4
-4
@@ -286,7 +286,7 @@ class JSI_EXPORT ISerialization : public ICast {
|
||||
/// It returns a shared pointer of an opaque Serialized object that can be
|
||||
/// deserialized multiple times. The lifetime of the Serialized object is not
|
||||
/// tied to the lifetime of the original object.
|
||||
virtual std::shared_ptr<Serialized> serialize(Value& value) = 0;
|
||||
virtual std::shared_ptr<Serialized> serialize(const Value& value) = 0;
|
||||
|
||||
/// Given a Serialized object provided by \p serialized, deserialize it using
|
||||
/// the structured clone algorithm into a JS value in the current runtime.
|
||||
@@ -302,7 +302,7 @@ class JSI_EXPORT ISerialization : public ICast {
|
||||
/// deserializeWithTransfer. The lifetime of the Serialized object is not tied
|
||||
/// to the lifetime of the original object.
|
||||
virtual std::unique_ptr<Serialized> serializeWithTransfer(
|
||||
Value& value,
|
||||
const Value& value,
|
||||
const Array& transferList) = 0;
|
||||
|
||||
/// Using the structure clone algorithm, deserialize the object provided by \p
|
||||
@@ -313,8 +313,8 @@ class JSI_EXPORT ISerialization : public ICast {
|
||||
/// serialized data entirely and make the serialized objects in the current
|
||||
/// runtime. Any transferred values in the serialized object will be owned by
|
||||
/// the current runtime.
|
||||
// This method returns an Array containing the deserialized values, where the
|
||||
// first element is the value passed into serializeWithTransfer,
|
||||
/// This method returns an Array containing the deserialized values, where
|
||||
/// the first element is the value passed into serializeWithTransfer,
|
||||
/// followed by all transferred values.
|
||||
virtual Array deserializeWithTransfer(
|
||||
std::unique_ptr<Serialized>& serialized) = 0;
|
||||
|
||||
Reference in new issue
Block a user