mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
fix TextInput 'contextMenuHidden' prop (#45014)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45014 `TextInput`'s `contextMenuHidden` prop isn't working working as expected. It should hide the context menu (copy/paste/...) that pops up from input text. Reference: [Android doc](https://developer.android.com/reference/android/widget/TextView#setCustomSelectionActionModeCallback(android.view.ActionMode.Callback)) > Returning false from `ActionMode.Callback.onCreateActionMode(ActionMode, android.view.Menu)` will prevent the action mode from being started. **Changelog:** [Android][Fixed] - TextInput's `contextMenuHidden` prop bug fix Reviewed By: javache Differential Revision: D58684366 fbshipit-source-id: 328c267ed0e896a78e114578e3a00adf41f2e095
This commit is contained in:
@@ -7732,6 +7732,7 @@ public class com/facebook/react/views/textinput/ReactEditText : androidx/appcomp
|
||||
public fun setBorderStyle (Ljava/lang/String;)V
|
||||
public fun setBorderWidth (IF)V
|
||||
public fun setContentSizeWatcher (Lcom/facebook/react/views/textinput/ContentSizeWatcher;)V
|
||||
public fun setContextMenuHidden (Z)V
|
||||
public fun setDisableFullscreenUI (Z)V
|
||||
public fun setFontFamily (Ljava/lang/String;)V
|
||||
public fun setFontFeatureSettings (Ljava/lang/String;)V
|
||||
|
||||
+8
@@ -118,6 +118,7 @@ public class ReactEditText extends AppCompatEditText {
|
||||
private int mFontWeight = ReactConstants.UNSET;
|
||||
private int mFontStyle = ReactConstants.UNSET;
|
||||
private boolean mAutoFocus = false;
|
||||
private boolean mContextMenuHidden = false;
|
||||
private boolean mDidAttachToWindow = false;
|
||||
private @Nullable String mPlaceholder = null;
|
||||
|
||||
@@ -191,6 +192,9 @@ public class ReactEditText extends AppCompatEditText {
|
||||
*/
|
||||
@Override
|
||||
public boolean onCreateActionMode(ActionMode mode, Menu menu) {
|
||||
if (mContextMenuHidden) {
|
||||
return false;
|
||||
}
|
||||
menu.removeItem(android.R.id.pasteAsPlainText);
|
||||
return true;
|
||||
}
|
||||
@@ -1121,6 +1125,10 @@ public class ReactEditText extends AppCompatEditText {
|
||||
mAutoFocus = autoFocus;
|
||||
}
|
||||
|
||||
public void setContextMenuHidden(boolean contextMenuHidden) {
|
||||
mContextMenuHidden = contextMenuHidden;
|
||||
}
|
||||
|
||||
protected void applyTextAttributes() {
|
||||
// In general, the `getEffective*` functions return `Float.NaN` if the
|
||||
// property hasn't been set.
|
||||
|
||||
+1
-8
@@ -651,14 +651,7 @@ public class ReactTextInputManager extends BaseViewManager<ReactEditText, Layout
|
||||
|
||||
@ReactProp(name = "contextMenuHidden", defaultBoolean = false)
|
||||
public void setContextMenuHidden(ReactEditText view, boolean contextMenuHidden) {
|
||||
final boolean _contextMenuHidden = contextMenuHidden;
|
||||
view.setOnLongClickListener(
|
||||
new View.OnLongClickListener() {
|
||||
public boolean onLongClick(View v) {
|
||||
return _contextMenuHidden;
|
||||
}
|
||||
;
|
||||
});
|
||||
view.setContextMenuHidden(contextMenuHidden);
|
||||
}
|
||||
|
||||
@ReactProp(name = "selectTextOnFocus", defaultBoolean = false)
|
||||
|
||||
Reference in New Issue
Block a user