Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make ResponseUtil internal (#49153)

Browse Source 
Summary:
As part of the initiative to reduce the public API surface, this class can be internalized. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.modules.network.ResponseUtil).

## Changelog:

[Android][Breaking] - Make com.facebook.react.modules.network.ResponseUtil internal

Pull Request resolved: https://github.com/facebook/react-native/pull/49153

Test Plan:
```bash
yarn test-android
yarn android
```

Reviewed By: fabriziocucci

Differential Revision: D69111691

Pulled By: javache

fbshipit-source-id: 985677316be7546d06119826bb53b78e1ae11d75
This commit is contained in:
Mateo Guzmán
2025-02-04 04:21:27 -08:00
committed by Facebook GitHub Bot
parent 1c51b77868
commit 360cbf7433
2 changed files with 9 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/api/ReactAndroid.api
-12
View File
@@ -3372,18 +3372,6 @@ public class com/facebook/react/modules/network/ProgressResponseBody : okhttp3/R
public fun totalBytesRead ()J
}
public final class com/facebook/react/modules/network/ResponseUtil {
public static final field INSTANCE Lcom/facebook/react/modules/network/ResponseUtil;
public static final fun onDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILcom/facebook/react/bridge/WritableMap;)V
public static final fun onDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;)V
public static final fun onDataReceivedProgress (Lcom/facebook/react/bridge/ReactApplicationContext;IJJ)V
public static final fun onDataSend (Lcom/facebook/react/bridge/ReactApplicationContext;IJJ)V
public static final fun onIncrementalDataReceived (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;JJ)V
public static final fun onRequestError (Lcom/facebook/react/bridge/ReactApplicationContext;ILjava/lang/String;Ljava/lang/Throwable;)V
public static final fun onRequestSuccess (Lcom/facebook/react/bridge/ReactApplicationContext;I)V
public static final fun onResponseReceived (Lcom/facebook/react/bridge/ReactApplicationContext;IILcom/facebook/react/bridge/WritableMap;Ljava/lang/String;)V
}
public class com/facebook/react/modules/network/TLSSocketFactory : javax/net/ssl/SSLSocketFactory {
public fun <init> ()V
public fun createSocket (Ljava/lang/String;I)Ljava/net/Socket;
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/ResponseUtil.kt
+9 -13
View File
@@ -13,9 +13,9 @@ import com.facebook.react.bridge.WritableMap
import java.net.SocketTimeoutException
/** Util methods to send network responses to JS. */
public object ResponseUtil {
internal object ResponseUtil {
@JvmStatic
public fun onDataSend(
fun onDataSend(
reactContext: ReactApplicationContext?,
requestId: Int,
progress: Long,
@@ -32,7 +32,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onIncrementalDataReceived(
fun onIncrementalDataReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
data: String?,
@@ -51,7 +51,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onDataReceivedProgress(
fun onDataReceivedProgress(
reactContext: ReactApplicationContext?,
requestId: Int,
progress: Long,
@@ -68,7 +68,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onDataReceived(reactContext: ReactApplicationContext?, requestId: Int, data: String?) {
fun onDataReceived(reactContext: ReactApplicationContext?, requestId: Int, data: String?) {
val args =
Arguments.createArray().apply {
pushInt(requestId)
@@ -79,11 +79,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onDataReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
data: WritableMap?
) {
fun onDataReceived(reactContext: ReactApplicationContext?, requestId: Int, data: WritableMap?) {
val args =
Arguments.createArray().apply {
pushInt(requestId)
@@ -94,7 +90,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onRequestError(
fun onRequestError(
reactContext: ReactApplicationContext?,
requestId: Int,
error: String?,
@@ -114,7 +110,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onRequestSuccess(reactContext: ReactApplicationContext?, requestId: Int) {
fun onRequestSuccess(reactContext: ReactApplicationContext?, requestId: Int) {
val args =
Arguments.createArray().apply {
pushInt(requestId)
@@ -125,7 +121,7 @@ public object ResponseUtil {
}
@JvmStatic
public fun onResponseReceived(
fun onResponseReceived(
reactContext: ReactApplicationContext?,
requestId: Int,
statusCode: Int,