mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Cover jsitooling with guards (#58262)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58262 Classifies `jsitooling:jsitooling` as a for-frameworks target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/FrameworksGuard.h>` to the module's three exported headers (`JSRuntimeBindings.h`, `JSRuntimeFactory.h`, `JSRuntimeFactoryCAPI.h`), and wires the guard dependency into BUCK, CMake and CocoaPods. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D118118424 fbshipit-source-id: 1c4af8e34d671d11d280404ade5f640119058b22
This commit is contained in:
1 parent
66de16dc6e
commit
3557ce1de3
5 files changed
+16
-1
No files matched your search
@@ -20,7 +20,8 @@ target_link_libraries(jsitooling
|
||||
react_cxxreact
|
||||
folly_runtime
|
||||
glog
|
||||
jsi)
|
||||
jsi
|
||||
react_cxxstableapi)
|
||||
|
||||
target_compile_reactnative_options(jsitooling PRIVATE)
|
||||
target_compile_options(jsitooling PRIVATE -Wpedantic)
|
||||
@@ -16,6 +16,12 @@ else
|
||||
source[:tag] = "v#{version}"
|
||||
end
|
||||
|
||||
header_search_paths = []
|
||||
|
||||
if ENV['USE_FRAMEWORKS']
|
||||
header_search_paths << "\"$(PODS_TARGET_SRCROOT)/..\"" # ReactCommon, for <react/cxxstableapi/...>
|
||||
end
|
||||
|
||||
Pod::Spec.new do |s|
|
||||
s.name = "React-jsitooling"
|
||||
s.version = version
|
||||
@@ -31,12 +37,14 @@ Pod::Spec.new do |s|
|
||||
resolve_use_frameworks(s, header_mappings_dir: "./", module_name: "JSITooling")
|
||||
|
||||
s.pod_target_xcconfig = {
|
||||
"HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
|
||||
"CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
|
||||
"DEFINES_MODULE" => "YES",
|
||||
}
|
||||
|
||||
s.dependency "React-cxxreact", version
|
||||
s.dependency "React-jsi", version
|
||||
s.dependency "React-cxxstableapi"
|
||||
add_dependency(s, "React-debug")
|
||||
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
|
||||
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#include <jsi/jsi.h>
|
||||
#include <string>
|
||||
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#ifdef __cplusplus
|
||||
|
||||
#include <jsi/jsi.h>
|
||||
|
||||
@@ -7,6 +7,8 @@
|
||||
|
||||
#pragma once
|
||||
|
||||
#include <react/cxxstableapi/FrameworksGuard.h>
|
||||
|
||||
#ifdef __cplusplus
|
||||
extern "C" {
|
||||
#endif
|
||||
|
||||
Reference in new issue
Block a user