Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Make Unused Not Compiler Specific (#34357)

Browse Source 
Summary:
Use of `__attribute__` and `__unused` is compiler specific. Opt for standard `[[maybe_unused]]` instead.

## Changelog

[General] [Fixed] - Remove compiler-specific syntax.

Pull Request resolved: https://github.com/facebook/react-native/pull/34357

Test Plan: Built on react-native-windows.

Reviewed By: cipolleschi

Differential Revision: D38498481

Pulled By: javache

fbshipit-source-id: af43206788f54dda3b747b6417e20096c7d520e8
This commit is contained in:
Chiara Mooney
2022-08-08 03:50:58 -07:00
committed by Facebook GitHub Bot
parent 60e7eb4d53
commit 33dbb6c40c
5 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/cxxreact/SampleCxxModule.cpp
+1 -1
View File
@@ -163,7 +163,7 @@ void SampleCxxModule::save(folly::dynamic args) {
sample_->save(std::move(m));
}
void SampleCxxModule::load(__unused folly::dynamic args, Callback cb) {
void SampleCxxModule::load([[maybe_unused]] folly::dynamic args, Callback cb) {
dynamic d = dynamic::object;
for (const auto &p : sample_->load()) {
d.insert(p.first, p.second);