diff --git a/React/Base/RCTModuleMethod.mm b/React/Base/RCTModuleMethod.mm index 941400a9f2d..f2d32d9aaf7 100644 --- a/React/Base/RCTModuleMethod.mm +++ b/React/Base/RCTModuleMethod.mm @@ -91,7 +91,7 @@ static BOOL RCTParseSelectorPart(const char **input, NSMutableString *selector) static BOOL RCTParseUnused(const char **input) { return RCTReadString(input, "__attribute__((unused))") || RCTReadString(input, "__attribute__((__unused__))") || - RCTReadString(input, "__unused"); + RCTReadString(input, "__unused") || RCTReadString(input, "[[maybe_unused]]"); } static RCTNullability RCTParseNullability(const char **input) diff --git a/ReactCommon/cxxreact/JSExecutor.h b/ReactCommon/cxxreact/JSExecutor.h index 18125ed0427..4d6e45f9c37 100644 --- a/ReactCommon/cxxreact/JSExecutor.h +++ b/ReactCommon/cxxreact/JSExecutor.h @@ -128,8 +128,7 @@ class RN_EXPORT JSExecutor { */ virtual std::string getDescription() = 0; - virtual void handleMemoryPressure(__attribute__((unused)) int pressureLevel) { - } + virtual void handleMemoryPressure([[maybe_unused]] int pressureLevel) {} virtual void destroy() {} virtual ~JSExecutor() {} diff --git a/ReactCommon/cxxreact/NativeToJsBridge.cpp b/ReactCommon/cxxreact/NativeToJsBridge.cpp index 88a933915e8..ce54a90dea0 100644 --- a/ReactCommon/cxxreact/NativeToJsBridge.cpp +++ b/ReactCommon/cxxreact/NativeToJsBridge.cpp @@ -52,7 +52,7 @@ class JsToNativeBridge : public react::ExecutorDelegate { } void callNativeModules( - __attribute__((unused)) JSExecutor &executor, + [[maybe_unused]] JSExecutor &executor, folly::dynamic &&calls, bool isEndOfBatch) override { CHECK(m_registry || calls.empty()) @@ -85,7 +85,7 @@ class JsToNativeBridge : public react::ExecutorDelegate { } MethodCallResult callSerializableNativeHook( - __attribute__((unused)) JSExecutor &executor, + [[maybe_unused]] JSExecutor &executor, unsigned int moduleId, unsigned int methodId, folly::dynamic &&args) override { diff --git a/ReactCommon/cxxreact/SampleCxxModule.cpp b/ReactCommon/cxxreact/SampleCxxModule.cpp index c84aa1594ec..2474be8ad68 100644 --- a/ReactCommon/cxxreact/SampleCxxModule.cpp +++ b/ReactCommon/cxxreact/SampleCxxModule.cpp @@ -163,7 +163,7 @@ void SampleCxxModule::save(folly::dynamic args) { sample_->save(std::move(m)); } -void SampleCxxModule::load(__unused folly::dynamic args, Callback cb) { +void SampleCxxModule::load([[maybe_unused]] folly::dynamic args, Callback cb) { dynamic d = dynamic::object; for (const auto &p : sample_->load()) { d.insert(p.first, p.second); diff --git a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp index d9fa242de9c..10552e0adae 100644 --- a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp +++ b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp @@ -173,7 +173,7 @@ void JSIExecutor::setBundleRegistry(std::unique_ptr r) { PropNameID::forAscii(*runtime_, "nativeRequire"), 2, [this]( - __unused Runtime &rt, + [[maybe_unused]] Runtime &rt, const facebook::jsi::Value &, const facebook::jsi::Value *args, size_t count) { return nativeRequire(args, count); }));