mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Remove hideOffscreenVirtualViewsOnIOS feature flag (#57225)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/57225 The `hideOffscreenVirtualViewsOnIOS` flag gated hiding of offscreen `VirtualView`s on iOS (setting `self.hidden`) in `RCTVirtualViewComponentView`. It was never ramped and is being removed. The flag defaulted to `false`, so the gated branches never set `hidden`; deleting them restores the pre-flag behavior. The now-unused `ReactNativeFeatureFlags.h` import is also removed. Removes the flag definition from `ReactNativeFeatureFlags.config.js`, the gated call sites in `RCTVirtualViewComponentView.mm`, and the regenerated feature-flag files (via `yarn featureflags --update`). Changelog: [Internal] Reviewed By: javache Differential Revision: D108411518 fbshipit-source-id: 50c5e6558b00c281bf143f780f6a029c9c876a18
This commit is contained in:
1 parent
8634ecb025
commit
3233436177
21 files changed
+47
-182
No files matched your search
-18
@@ -16,7 +16,6 @@
|
||||
#import <React/UIView+React.h>
|
||||
#import <jsi/jsi.h>
|
||||
|
||||
#import <react/featureflags/ReactNativeFeatureFlags.h>
|
||||
#import <react/renderer/components/FBReactNativeSpec/ComponentDescriptors.h>
|
||||
#import <react/renderer/components/FBReactNativeSpec/EventEmitters.h>
|
||||
#import <react/renderer/components/FBReactNativeSpec/Props.h>
|
||||
@@ -65,9 +64,6 @@ using namespace facebook::react;
|
||||
|
||||
if (!_mode.has_value()) {
|
||||
_mode = newViewProps.initialHidden ? RCTVirtualViewModeHidden : RCTVirtualViewModeVisible;
|
||||
if (ReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS()) {
|
||||
self.hidden = newViewProps.initialHidden && !sIsAccessibilityUsed;
|
||||
}
|
||||
}
|
||||
|
||||
switch (newViewProps.renderState) {
|
||||
@@ -211,20 +207,6 @@ static BOOL sIsAccessibilityUsed = NO;
|
||||
[self _dispatchAsyncModeChange:event];
|
||||
break;
|
||||
}
|
||||
|
||||
if (ReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS()) {
|
||||
switch (newMode) {
|
||||
case RCTVirtualViewModeVisible:
|
||||
self.hidden = NO;
|
||||
break;
|
||||
case RCTVirtualViewModePrerender:
|
||||
self.hidden = !sIsAccessibilityUsed;
|
||||
break;
|
||||
case RCTVirtualViewModeHidden:
|
||||
self.hidden = YES;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
#pragma mark - Private API
|
||||
|
||||
+1
-7
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<5307fff9429956a3f3f2f54f2b6b00e7>>
|
||||
* @generated SignedSource<<17567d3adfba54ec2f888b50dae9efb8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -384,12 +384,6 @@ public object ReactNativeFeatureFlags {
|
||||
@JvmStatic
|
||||
public fun fuseboxScreenshotCaptureEnabled(): Boolean = accessor.fuseboxScreenshotCaptureEnabled()
|
||||
|
||||
/**
|
||||
* Hides offscreen VirtualViews on iOS by setting hidden = YES to avoid extra cost of views
|
||||
*/
|
||||
@JvmStatic
|
||||
public fun hideOffscreenVirtualViewsOnIOS(): Boolean = accessor.hideOffscreenVirtualViewsOnIOS()
|
||||
|
||||
/**
|
||||
* When enabled, uses optimized platform-specific paths to apply animated props synchronously. On Android, this uses a batched int/double buffer protocol with a single JNI call. On iOS, this passes AnimatedProps directly through the delegate chain and applies them via cloneProps, avoiding the folly::dynamic round-trip.
|
||||
*/
|
||||
|
||||
+1
-11
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<d179182254004aa1f5adf671eccb953f>>
|
||||
* @generated SignedSource<<337b652caa9d443c8d83915e22210198>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -79,7 +79,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
private var fuseboxFrameRecordingEnabledCache: Boolean? = null
|
||||
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
|
||||
private var fuseboxScreenshotCaptureEnabledCache: Boolean? = null
|
||||
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
|
||||
private var optimizedAnimatedPropUpdatesCache: Boolean? = null
|
||||
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
|
||||
private var perfIssuesEnabledCache: Boolean? = null
|
||||
@@ -639,15 +638,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun hideOffscreenVirtualViewsOnIOS(): Boolean {
|
||||
var cached = hideOffscreenVirtualViewsOnIOSCache
|
||||
if (cached == null) {
|
||||
cached = ReactNativeFeatureFlagsCxxInterop.hideOffscreenVirtualViewsOnIOS()
|
||||
hideOffscreenVirtualViewsOnIOSCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun optimizedAnimatedPropUpdates(): Boolean {
|
||||
var cached = optimizedAnimatedPropUpdatesCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<6dc403c11108a657d48ec9573bee842f>>
|
||||
* @generated SignedSource<<b74d90991a4808bd1f3abfa75f3adcde>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -146,8 +146,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun fuseboxScreenshotCaptureEnabled(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun hideOffscreenVirtualViewsOnIOS(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun optimizedAnimatedPropUpdates(): Boolean
|
||||
|
||||
@DoNotStrip @JvmStatic public external fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<452edce222866440ff3794deb178a7f4>>
|
||||
* @generated SignedSource<<efb2b99bb1697ec28c59e4d2244717ad>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -141,8 +141,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
|
||||
|
||||
override fun fuseboxScreenshotCaptureEnabled(): Boolean = false
|
||||
|
||||
override fun hideOffscreenVirtualViewsOnIOS(): Boolean = false
|
||||
|
||||
override fun optimizedAnimatedPropUpdates(): Boolean = false
|
||||
|
||||
override fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = true
|
||||
|
||||
+1
-12
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<8ba7f19e8afe329937b1b36d3b83dbc5>>
|
||||
* @generated SignedSource<<164c9c2751f660ee098c12b8cf2c8b66>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -83,7 +83,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
private var fuseboxFrameRecordingEnabledCache: Boolean? = null
|
||||
private var fuseboxNetworkInspectionEnabledCache: Boolean? = null
|
||||
private var fuseboxScreenshotCaptureEnabledCache: Boolean? = null
|
||||
private var hideOffscreenVirtualViewsOnIOSCache: Boolean? = null
|
||||
private var optimizedAnimatedPropUpdatesCache: Boolean? = null
|
||||
private var overrideBySynchronousMountPropsAtMountingAndroidCache: Boolean? = null
|
||||
private var perfIssuesEnabledCache: Boolean? = null
|
||||
@@ -702,16 +701,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun hideOffscreenVirtualViewsOnIOS(): Boolean {
|
||||
var cached = hideOffscreenVirtualViewsOnIOSCache
|
||||
if (cached == null) {
|
||||
cached = currentProvider.hideOffscreenVirtualViewsOnIOS()
|
||||
accessedFeatureFlags.add("hideOffscreenVirtualViewsOnIOS")
|
||||
hideOffscreenVirtualViewsOnIOSCache = cached
|
||||
}
|
||||
return cached
|
||||
}
|
||||
|
||||
override fun optimizedAnimatedPropUpdates(): Boolean {
|
||||
var cached = optimizedAnimatedPropUpdatesCache
|
||||
if (cached == null) {
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<3a3f9014f644b6b964b50d0974a7b9b5>>
|
||||
* @generated SignedSource<<b9cfc6790e36d7f7ff0ce9b87edca1e8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -141,8 +141,6 @@ public interface ReactNativeFeatureFlagsProvider {
|
||||
|
||||
@DoNotStrip public fun fuseboxScreenshotCaptureEnabled(): Boolean
|
||||
|
||||
@DoNotStrip public fun hideOffscreenVirtualViewsOnIOS(): Boolean
|
||||
|
||||
@DoNotStrip public fun optimizedAnimatedPropUpdates(): Boolean
|
||||
|
||||
@DoNotStrip public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean
|
||||
|
||||
+1
-15
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<70e4f4b4bb3aa28a644ede80ceeb4fc3>>
|
||||
* @generated SignedSource<<ff63bb537a04e29fdb97e9d87fb7570c>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -393,12 +393,6 @@ class ReactNativeFeatureFlagsJavaProvider
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool hideOffscreenVirtualViewsOnIOS() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("hideOffscreenVirtualViewsOnIOS");
|
||||
return method(javaProvider_);
|
||||
}
|
||||
|
||||
bool optimizedAnimatedPropUpdates() override {
|
||||
static const auto method =
|
||||
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("optimizedAnimatedPropUpdates");
|
||||
@@ -860,11 +854,6 @@ bool JReactNativeFeatureFlagsCxxInterop::fuseboxScreenshotCaptureEnabled(
|
||||
return ReactNativeFeatureFlags::fuseboxScreenshotCaptureEnabled();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::hideOffscreenVirtualViewsOnIOS(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS();
|
||||
}
|
||||
|
||||
bool JReactNativeFeatureFlagsCxxInterop::optimizedAnimatedPropUpdates(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
|
||||
return ReactNativeFeatureFlags::optimizedAnimatedPropUpdates();
|
||||
@@ -1208,9 +1197,6 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
|
||||
makeNativeMethod(
|
||||
"fuseboxScreenshotCaptureEnabled",
|
||||
JReactNativeFeatureFlagsCxxInterop::fuseboxScreenshotCaptureEnabled),
|
||||
makeNativeMethod(
|
||||
"hideOffscreenVirtualViewsOnIOS",
|
||||
JReactNativeFeatureFlagsCxxInterop::hideOffscreenVirtualViewsOnIOS),
|
||||
makeNativeMethod(
|
||||
"optimizedAnimatedPropUpdates",
|
||||
JReactNativeFeatureFlagsCxxInterop::optimizedAnimatedPropUpdates),
|
||||
|
||||
+1
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<19ab9f9ec4e3470290f69e0803ade5d4>>
|
||||
* @generated SignedSource<<a61fa73c8b01506a3eb1caa411a5854f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -207,9 +207,6 @@ class JReactNativeFeatureFlagsCxxInterop
|
||||
static bool fuseboxScreenshotCaptureEnabled(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool hideOffscreenVirtualViewsOnIOS(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
static bool optimizedAnimatedPropUpdates(
|
||||
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<de5333acce3cebc8c1f88e7d95b111e8>>
|
||||
* @generated SignedSource<<dae2de640250ff7281b56633c75712d8>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -262,10 +262,6 @@ bool ReactNativeFeatureFlags::fuseboxScreenshotCaptureEnabled() {
|
||||
return getAccessor().fuseboxScreenshotCaptureEnabled();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS() {
|
||||
return getAccessor().hideOffscreenVirtualViewsOnIOS();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlags::optimizedAnimatedPropUpdates() {
|
||||
return getAccessor().optimizedAnimatedPropUpdates();
|
||||
}
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<9180537aa2031cfcbab5ffbdf1dc32d1>>
|
||||
* @generated SignedSource<<e757dc80972dc0f4810cc3713516402d>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -334,11 +334,6 @@ class ReactNativeFeatureFlags {
|
||||
*/
|
||||
RN_EXPORT static bool fuseboxScreenshotCaptureEnabled();
|
||||
|
||||
/**
|
||||
* Hides offscreen VirtualViews on iOS by setting hidden = YES to avoid extra cost of views
|
||||
*/
|
||||
RN_EXPORT static bool hideOffscreenVirtualViewsOnIOS();
|
||||
|
||||
/**
|
||||
* When enabled, uses optimized platform-specific paths to apply animated props synchronously. On Android, this uses a batched int/double buffer protocol with a single JNI call. On iOS, this passes AnimatedProps directly through the delegate chain and applies them via cloneProps, avoiding the folly::dynamic round-trip.
|
||||
*/
|
||||
|
||||
+28
-46
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<804a4710d98f97c94928b77ad2cab2f7>>
|
||||
* @generated SignedSource<<1c4a88ac3f4f2d04d2e9d986536df7d9>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -1091,24 +1091,6 @@ bool ReactNativeFeatureFlagsAccessor::fuseboxScreenshotCaptureEnabled() {
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::hideOffscreenVirtualViewsOnIOS() {
|
||||
auto flagValue = hideOffscreenVirtualViewsOnIOS_.load();
|
||||
|
||||
if (!flagValue.has_value()) {
|
||||
// This block is not exclusive but it is not necessary.
|
||||
// If multiple threads try to initialize the feature flag, we would only
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(59, "hideOffscreenVirtualViewsOnIOS");
|
||||
|
||||
flagValue = currentProvider_->hideOffscreenVirtualViewsOnIOS();
|
||||
hideOffscreenVirtualViewsOnIOS_ = flagValue;
|
||||
}
|
||||
|
||||
return flagValue.value();
|
||||
}
|
||||
|
||||
bool ReactNativeFeatureFlagsAccessor::optimizedAnimatedPropUpdates() {
|
||||
auto flagValue = optimizedAnimatedPropUpdates_.load();
|
||||
|
||||
@@ -1118,7 +1100,7 @@ bool ReactNativeFeatureFlagsAccessor::optimizedAnimatedPropUpdates() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(60, "optimizedAnimatedPropUpdates");
|
||||
markFlagAsAccessed(59, "optimizedAnimatedPropUpdates");
|
||||
|
||||
flagValue = currentProvider_->optimizedAnimatedPropUpdates();
|
||||
optimizedAnimatedPropUpdates_ = flagValue;
|
||||
@@ -1136,7 +1118,7 @@ bool ReactNativeFeatureFlagsAccessor::overrideBySynchronousMountPropsAtMountingA
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(61, "overrideBySynchronousMountPropsAtMountingAndroid");
|
||||
markFlagAsAccessed(60, "overrideBySynchronousMountPropsAtMountingAndroid");
|
||||
|
||||
flagValue = currentProvider_->overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
overrideBySynchronousMountPropsAtMountingAndroid_ = flagValue;
|
||||
@@ -1154,7 +1136,7 @@ bool ReactNativeFeatureFlagsAccessor::perfIssuesEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(62, "perfIssuesEnabled");
|
||||
markFlagAsAccessed(61, "perfIssuesEnabled");
|
||||
|
||||
flagValue = currentProvider_->perfIssuesEnabled();
|
||||
perfIssuesEnabled_ = flagValue;
|
||||
@@ -1172,7 +1154,7 @@ bool ReactNativeFeatureFlagsAccessor::perfMonitorV2Enabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(63, "perfMonitorV2Enabled");
|
||||
markFlagAsAccessed(62, "perfMonitorV2Enabled");
|
||||
|
||||
flagValue = currentProvider_->perfMonitorV2Enabled();
|
||||
perfMonitorV2Enabled_ = flagValue;
|
||||
@@ -1190,7 +1172,7 @@ double ReactNativeFeatureFlagsAccessor::preparedTextCacheSize() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(64, "preparedTextCacheSize");
|
||||
markFlagAsAccessed(63, "preparedTextCacheSize");
|
||||
|
||||
flagValue = currentProvider_->preparedTextCacheSize();
|
||||
preparedTextCacheSize_ = flagValue;
|
||||
@@ -1208,7 +1190,7 @@ bool ReactNativeFeatureFlagsAccessor::preventShadowTreeCommitExhaustion() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(65, "preventShadowTreeCommitExhaustion");
|
||||
markFlagAsAccessed(64, "preventShadowTreeCommitExhaustion");
|
||||
|
||||
flagValue = currentProvider_->preventShadowTreeCommitExhaustion();
|
||||
preventShadowTreeCommitExhaustion_ = flagValue;
|
||||
@@ -1226,7 +1208,7 @@ bool ReactNativeFeatureFlagsAccessor::redBoxV2Android() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(66, "redBoxV2Android");
|
||||
markFlagAsAccessed(65, "redBoxV2Android");
|
||||
|
||||
flagValue = currentProvider_->redBoxV2Android();
|
||||
redBoxV2Android_ = flagValue;
|
||||
@@ -1244,7 +1226,7 @@ bool ReactNativeFeatureFlagsAccessor::redBoxV2IOS() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(67, "redBoxV2IOS");
|
||||
markFlagAsAccessed(66, "redBoxV2IOS");
|
||||
|
||||
flagValue = currentProvider_->redBoxV2IOS();
|
||||
redBoxV2IOS_ = flagValue;
|
||||
@@ -1262,7 +1244,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldPressibilityUseW3CPointerEventsForHo
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(68, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
markFlagAsAccessed(67, "shouldPressibilityUseW3CPointerEventsForHover");
|
||||
|
||||
flagValue = currentProvider_->shouldPressibilityUseW3CPointerEventsForHover();
|
||||
shouldPressibilityUseW3CPointerEventsForHover_ = flagValue;
|
||||
@@ -1280,7 +1262,7 @@ bool ReactNativeFeatureFlagsAccessor::shouldTriggerResponderTransferOnScrollAndr
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(69, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
markFlagAsAccessed(68, "shouldTriggerResponderTransferOnScrollAndroid");
|
||||
|
||||
flagValue = currentProvider_->shouldTriggerResponderTransferOnScrollAndroid();
|
||||
shouldTriggerResponderTransferOnScrollAndroid_ = flagValue;
|
||||
@@ -1298,7 +1280,7 @@ bool ReactNativeFeatureFlagsAccessor::skipActivityIdentityAssertionOnHostPause()
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(70, "skipActivityIdentityAssertionOnHostPause");
|
||||
markFlagAsAccessed(69, "skipActivityIdentityAssertionOnHostPause");
|
||||
|
||||
flagValue = currentProvider_->skipActivityIdentityAssertionOnHostPause();
|
||||
skipActivityIdentityAssertionOnHostPause_ = flagValue;
|
||||
@@ -1316,7 +1298,7 @@ bool ReactNativeFeatureFlagsAccessor::syncAndroidClipBoundsWithOverflow() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(71, "syncAndroidClipBoundsWithOverflow");
|
||||
markFlagAsAccessed(70, "syncAndroidClipBoundsWithOverflow");
|
||||
|
||||
flagValue = currentProvider_->syncAndroidClipBoundsWithOverflow();
|
||||
syncAndroidClipBoundsWithOverflow_ = flagValue;
|
||||
@@ -1334,7 +1316,7 @@ bool ReactNativeFeatureFlagsAccessor::traceTurboModulePromiseRejectionsOnAndroid
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(72, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
markFlagAsAccessed(71, "traceTurboModulePromiseRejectionsOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->traceTurboModulePromiseRejectionsOnAndroid();
|
||||
traceTurboModulePromiseRejectionsOnAndroid_ = flagValue;
|
||||
@@ -1352,7 +1334,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommit(
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(73, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
markFlagAsAccessed(72, "updateRuntimeShadowNodeReferencesOnCommit");
|
||||
|
||||
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommit();
|
||||
updateRuntimeShadowNodeReferencesOnCommit_ = flagValue;
|
||||
@@ -1370,7 +1352,7 @@ bool ReactNativeFeatureFlagsAccessor::updateRuntimeShadowNodeReferencesOnCommitT
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(74, "updateRuntimeShadowNodeReferencesOnCommitThread");
|
||||
markFlagAsAccessed(73, "updateRuntimeShadowNodeReferencesOnCommitThread");
|
||||
|
||||
flagValue = currentProvider_->updateRuntimeShadowNodeReferencesOnCommitThread();
|
||||
updateRuntimeShadowNodeReferencesOnCommitThread_ = flagValue;
|
||||
@@ -1388,7 +1370,7 @@ bool ReactNativeFeatureFlagsAccessor::useAlwaysAvailableJSErrorHandling() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(75, "useAlwaysAvailableJSErrorHandling");
|
||||
markFlagAsAccessed(74, "useAlwaysAvailableJSErrorHandling");
|
||||
|
||||
flagValue = currentProvider_->useAlwaysAvailableJSErrorHandling();
|
||||
useAlwaysAvailableJSErrorHandling_ = flagValue;
|
||||
@@ -1406,7 +1388,7 @@ bool ReactNativeFeatureFlagsAccessor::useFabricInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(76, "useFabricInterop");
|
||||
markFlagAsAccessed(75, "useFabricInterop");
|
||||
|
||||
flagValue = currentProvider_->useFabricInterop();
|
||||
useFabricInterop_ = flagValue;
|
||||
@@ -1424,7 +1406,7 @@ bool ReactNativeFeatureFlagsAccessor::useNativeViewConfigsInBridgelessMode() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(77, "useNativeViewConfigsInBridgelessMode");
|
||||
markFlagAsAccessed(76, "useNativeViewConfigsInBridgelessMode");
|
||||
|
||||
flagValue = currentProvider_->useNativeViewConfigsInBridgelessMode();
|
||||
useNativeViewConfigsInBridgelessMode_ = flagValue;
|
||||
@@ -1442,7 +1424,7 @@ bool ReactNativeFeatureFlagsAccessor::useNestedScrollViewAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(78, "useNestedScrollViewAndroid");
|
||||
markFlagAsAccessed(77, "useNestedScrollViewAndroid");
|
||||
|
||||
flagValue = currentProvider_->useNestedScrollViewAndroid();
|
||||
useNestedScrollViewAndroid_ = flagValue;
|
||||
@@ -1460,7 +1442,7 @@ bool ReactNativeFeatureFlagsAccessor::useOptimizedViewRegistryOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(79, "useOptimizedViewRegistryOnAndroid");
|
||||
markFlagAsAccessed(78, "useOptimizedViewRegistryOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useOptimizedViewRegistryOnAndroid();
|
||||
useOptimizedViewRegistryOnAndroid_ = flagValue;
|
||||
@@ -1478,7 +1460,7 @@ bool ReactNativeFeatureFlagsAccessor::useSharedAnimatedBackend() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(80, "useSharedAnimatedBackend");
|
||||
markFlagAsAccessed(79, "useSharedAnimatedBackend");
|
||||
|
||||
flagValue = currentProvider_->useSharedAnimatedBackend();
|
||||
useSharedAnimatedBackend_ = flagValue;
|
||||
@@ -1496,7 +1478,7 @@ bool ReactNativeFeatureFlagsAccessor::useTraitHiddenOnAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(81, "useTraitHiddenOnAndroid");
|
||||
markFlagAsAccessed(80, "useTraitHiddenOnAndroid");
|
||||
|
||||
flagValue = currentProvider_->useTraitHiddenOnAndroid();
|
||||
useTraitHiddenOnAndroid_ = flagValue;
|
||||
@@ -1514,7 +1496,7 @@ bool ReactNativeFeatureFlagsAccessor::useTurboModuleInterop() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(82, "useTurboModuleInterop");
|
||||
markFlagAsAccessed(81, "useTurboModuleInterop");
|
||||
|
||||
flagValue = currentProvider_->useTurboModuleInterop();
|
||||
useTurboModuleInterop_ = flagValue;
|
||||
@@ -1532,7 +1514,7 @@ double ReactNativeFeatureFlagsAccessor::viewCullingOutsetRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(83, "viewCullingOutsetRatio");
|
||||
markFlagAsAccessed(82, "viewCullingOutsetRatio");
|
||||
|
||||
flagValue = currentProvider_->viewCullingOutsetRatio();
|
||||
viewCullingOutsetRatio_ = flagValue;
|
||||
@@ -1550,7 +1532,7 @@ bool ReactNativeFeatureFlagsAccessor::viewTransitionEnabled() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(84, "viewTransitionEnabled");
|
||||
markFlagAsAccessed(83, "viewTransitionEnabled");
|
||||
|
||||
flagValue = currentProvider_->viewTransitionEnabled();
|
||||
viewTransitionEnabled_ = flagValue;
|
||||
@@ -1568,7 +1550,7 @@ bool ReactNativeFeatureFlagsAccessor::viewTransitionUseHardwareBitmapAndroid() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(85, "viewTransitionUseHardwareBitmapAndroid");
|
||||
markFlagAsAccessed(84, "viewTransitionUseHardwareBitmapAndroid");
|
||||
|
||||
flagValue = currentProvider_->viewTransitionUseHardwareBitmapAndroid();
|
||||
viewTransitionUseHardwareBitmapAndroid_ = flagValue;
|
||||
@@ -1586,7 +1568,7 @@ double ReactNativeFeatureFlagsAccessor::virtualViewPrerenderRatio() {
|
||||
// be accessing the provider multiple times but the end state of this
|
||||
// instance and the returned flag value would be the same.
|
||||
|
||||
markFlagAsAccessed(86, "virtualViewPrerenderRatio");
|
||||
markFlagAsAccessed(85, "virtualViewPrerenderRatio");
|
||||
|
||||
flagValue = currentProvider_->virtualViewPrerenderRatio();
|
||||
virtualViewPrerenderRatio_ = flagValue;
|
||||
|
||||
+2
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<05c5b9db2533ee81fb2f10149d2d6bd5>>
|
||||
* @generated SignedSource<<9961a0c8efe857161fb861f2873a3749>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -91,7 +91,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
bool fuseboxFrameRecordingEnabled();
|
||||
bool fuseboxNetworkInspectionEnabled();
|
||||
bool fuseboxScreenshotCaptureEnabled();
|
||||
bool hideOffscreenVirtualViewsOnIOS();
|
||||
bool optimizedAnimatedPropUpdates();
|
||||
bool overrideBySynchronousMountPropsAtMountingAndroid();
|
||||
bool perfIssuesEnabled();
|
||||
@@ -130,7 +129,7 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::unique_ptr<ReactNativeFeatureFlagsProvider> currentProvider_;
|
||||
bool wasOverridden_;
|
||||
|
||||
std::array<std::atomic<const char*>, 87> accessedFeatureFlags_;
|
||||
std::array<std::atomic<const char*>, 86> accessedFeatureFlags_;
|
||||
|
||||
std::atomic<std::optional<bool>> commonTestFlag_;
|
||||
std::atomic<std::optional<bool>> cdpInteractionMetricsEnabled_;
|
||||
@@ -191,7 +190,6 @@ class ReactNativeFeatureFlagsAccessor {
|
||||
std::atomic<std::optional<bool>> fuseboxFrameRecordingEnabled_;
|
||||
std::atomic<std::optional<bool>> fuseboxNetworkInspectionEnabled_;
|
||||
std::atomic<std::optional<bool>> fuseboxScreenshotCaptureEnabled_;
|
||||
std::atomic<std::optional<bool>> hideOffscreenVirtualViewsOnIOS_;
|
||||
std::atomic<std::optional<bool>> optimizedAnimatedPropUpdates_;
|
||||
std::atomic<std::optional<bool>> overrideBySynchronousMountPropsAtMountingAndroid_;
|
||||
std::atomic<std::optional<bool>> perfIssuesEnabled_;
|
||||
|
||||
+1
-5
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<e731be7a8447fdf5c352b51bc56faac9>>
|
||||
* @generated SignedSource<<f4523dc9a6a32251533466d67a735e1f>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -263,10 +263,6 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool hideOffscreenVirtualViewsOnIOS() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
bool optimizedAnimatedPropUpdates() override {
|
||||
return false;
|
||||
}
|
||||
|
||||
+1
-10
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<ce3160b6321ac477feb370b2bf97bb7f>>
|
||||
* @generated SignedSource<<6db86679458aa76ebb30082ba12a32ae>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -576,15 +576,6 @@ class ReactNativeFeatureFlagsDynamicProvider : public ReactNativeFeatureFlagsDef
|
||||
return ReactNativeFeatureFlagsDefaults::fuseboxScreenshotCaptureEnabled();
|
||||
}
|
||||
|
||||
bool hideOffscreenVirtualViewsOnIOS() override {
|
||||
auto value = values_["hideOffscreenVirtualViewsOnIOS"];
|
||||
if (!value.isNull()) {
|
||||
return value.getBool();
|
||||
}
|
||||
|
||||
return ReactNativeFeatureFlagsDefaults::hideOffscreenVirtualViewsOnIOS();
|
||||
}
|
||||
|
||||
bool optimizedAnimatedPropUpdates() override {
|
||||
auto value = values_["optimizedAnimatedPropUpdates"];
|
||||
if (!value.isNull()) {
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c983b7bba4ca0e68668f6ad85518b03f>>
|
||||
* @generated SignedSource<<b7eb9be59de2e2a8622aa55f543c5862>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -84,7 +84,6 @@ class ReactNativeFeatureFlagsProvider {
|
||||
virtual bool fuseboxFrameRecordingEnabled() = 0;
|
||||
virtual bool fuseboxNetworkInspectionEnabled() = 0;
|
||||
virtual bool fuseboxScreenshotCaptureEnabled() = 0;
|
||||
virtual bool hideOffscreenVirtualViewsOnIOS() = 0;
|
||||
virtual bool optimizedAnimatedPropUpdates() = 0;
|
||||
virtual bool overrideBySynchronousMountPropsAtMountingAndroid() = 0;
|
||||
virtual bool perfIssuesEnabled() = 0;
|
||||
|
||||
+1
-6
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<fa57c41efc265a328b3b98e955763b25>>
|
||||
* @generated SignedSource<<bc20b5e74b97af62d7db4770c167fd36>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -339,11 +339,6 @@ bool NativeReactNativeFeatureFlags::fuseboxScreenshotCaptureEnabled(
|
||||
return ReactNativeFeatureFlags::fuseboxScreenshotCaptureEnabled();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::hideOffscreenVirtualViewsOnIOS();
|
||||
}
|
||||
|
||||
bool NativeReactNativeFeatureFlags::optimizedAnimatedPropUpdates(
|
||||
jsi::Runtime& /*runtime*/) {
|
||||
return ReactNativeFeatureFlags::optimizedAnimatedPropUpdates();
|
||||
|
||||
+1
-3
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<73dbb47c8b78009dd8212c19adf51dc0>>
|
||||
* @generated SignedSource<<e042e064a951f6063cb8e685f75fbc29>>
|
||||
*/
|
||||
|
||||
/**
|
||||
@@ -154,8 +154,6 @@ class NativeReactNativeFeatureFlags
|
||||
|
||||
bool fuseboxScreenshotCaptureEnabled(jsi::Runtime& runtime);
|
||||
|
||||
bool hideOffscreenVirtualViewsOnIOS(jsi::Runtime& runtime);
|
||||
|
||||
bool optimizedAnimatedPropUpdates(jsi::Runtime& runtime);
|
||||
|
||||
bool overrideBySynchronousMountPropsAtMountingAndroid(jsi::Runtime& runtime);
|
||||
|
||||
@@ -679,17 +679,6 @@ const definitions: FeatureFlagDefinitions = {
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
hideOffscreenVirtualViewsOnIOS: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
dateAdded: '2025-06-30',
|
||||
description:
|
||||
'Hides offscreen VirtualViews on iOS by setting hidden = YES to avoid extra cost of views',
|
||||
expectedReleaseValue: true,
|
||||
purpose: 'experimentation',
|
||||
},
|
||||
ossReleaseStage: 'none',
|
||||
},
|
||||
optimizedAnimatedPropUpdates: {
|
||||
defaultValue: false,
|
||||
metadata: {
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<c909315f72b17d08b477cbfda4eff531>>
|
||||
* @generated SignedSource<<785d84f617e6b1870c3ff1eeed9f1c66>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -108,7 +108,6 @@ export type ReactNativeFeatureFlags = Readonly<{
|
||||
fuseboxFrameRecordingEnabled: Getter<boolean>,
|
||||
fuseboxNetworkInspectionEnabled: Getter<boolean>,
|
||||
fuseboxScreenshotCaptureEnabled: Getter<boolean>,
|
||||
hideOffscreenVirtualViewsOnIOS: Getter<boolean>,
|
||||
optimizedAnimatedPropUpdates: Getter<boolean>,
|
||||
overrideBySynchronousMountPropsAtMountingAndroid: Getter<boolean>,
|
||||
perfIssuesEnabled: Getter<boolean>,
|
||||
@@ -448,10 +447,6 @@ export const fuseboxNetworkInspectionEnabled: Getter<boolean> = createNativeFlag
|
||||
* Enable Page.captureScreenshot CDP method support in the React Native DevTools CDP backend. This flag is global and should not be changed across React Host lifetimes.
|
||||
*/
|
||||
export const fuseboxScreenshotCaptureEnabled: Getter<boolean> = createNativeFlagGetter('fuseboxScreenshotCaptureEnabled', false);
|
||||
/**
|
||||
* Hides offscreen VirtualViews on iOS by setting hidden = YES to avoid extra cost of views
|
||||
*/
|
||||
export const hideOffscreenVirtualViewsOnIOS: Getter<boolean> = createNativeFlagGetter('hideOffscreenVirtualViewsOnIOS', false);
|
||||
/**
|
||||
* When enabled, uses optimized platform-specific paths to apply animated props synchronously. On Android, this uses a batched int/double buffer protocol with a single JNI call. On iOS, this passes AnimatedProps directly through the delegate chain and applies them via cloneProps, avoiding the folly::dynamic round-trip.
|
||||
*/
|
||||
|
||||
+1
-2
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<7b1756a74caa546933eebb934d27de12>>
|
||||
* @generated SignedSource<<4f1cda704a4ec31a005ded7ee8df3cbf>>
|
||||
* @flow strict
|
||||
* @noformat
|
||||
*/
|
||||
@@ -84,7 +84,6 @@ export interface Spec extends TurboModule {
|
||||
readonly fuseboxFrameRecordingEnabled?: () => boolean;
|
||||
readonly fuseboxNetworkInspectionEnabled?: () => boolean;
|
||||
readonly fuseboxScreenshotCaptureEnabled?: () => boolean;
|
||||
readonly hideOffscreenVirtualViewsOnIOS?: () => boolean;
|
||||
readonly optimizedAnimatedPropUpdates?: () => boolean;
|
||||
readonly overrideBySynchronousMountPropsAtMountingAndroid?: () => boolean;
|
||||
readonly perfIssuesEnabled?: () => boolean;
|
||||
|
||||
Reference in new issue
Block a user