Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disabled cpp view managers in runtime

Browse Source 
Summary:
We found this feature crashing the app during hot reload, and as there is no user code dependent on it so far, we decided to disable it until we find the root cause.

changelog: [internal] internal

Reviewed By: mdvacca

Differential Revision: D40445312

fbshipit-source-id: fe28b58c5dca6c91389ad38675ca37669a4965a0
This commit is contained in:
Arthur Kushka
2022-10-17 16:17:17 -07:00
committed by Facebook GitHub Bot
parent 55fca7fd38
commit 31f219977d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/jni/react/fabric/Binding.cpp
+5 -3
View File
@@ -377,9 +377,11 @@ void Binding::installFabricUIManager(
<< this << ").";
}
sharedCppComponentRegistry_ =
std::shared_ptr<const facebook::react::CppComponentRegistry>(
cppComponentRegistry ? cppComponentRegistry : nullptr);
// TODO[T135327389]: Investigate why code relying on CppComponentRegistry
// crashing during hot reload restart.
// sharedCppComponentRegistry_ =
// std::shared_ptr<const facebook::react::CppComponentRegistry>(
// cppComponentRegistry ? cppComponentRegistry : nullptr);
// Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes
// at the same time