mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Add cookie URL validation check to prevent crash (#55787)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55787 Add defensive check to validate components.URL before using it to load cookies. If NSURLComponents fails to parse the URL or returns nil for components.URL, this prevents passing nil to cookiesForURL which could cause issues in the network stack. Changelog: [Internal] Reviewed By: javache Differential Revision: D94375528 fbshipit-source-id: 499b9ed9c7661b43819b0a2b15edd62775d380f7
This commit is contained in:
1 parent
d5b2827401
commit
312d58eb01
1 file changed
+6
-2
@@ -84,8 +84,12 @@ RCT_EXPORT_METHOD(
|
||||
}
|
||||
|
||||
// Load and set the cookie header.
|
||||
NSArray<NSHTTPCookie *> *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:components.URL];
|
||||
request.allHTTPHeaderFields = [NSHTTPCookie requestHeaderFieldsWithCookies:cookies];
|
||||
if (components != nil && components.URL != nil) {
|
||||
NSArray<NSHTTPCookie *> *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:components.URL];
|
||||
request.allHTTPHeaderFields = [NSHTTPCookie requestHeaderFieldsWithCookies:cookies];
|
||||
} else {
|
||||
RCTLogError(@"RCTWebSocketModule: Invalid URL components - components or components.URL is nil");
|
||||
}
|
||||
|
||||
// Load supplied headers
|
||||
if ([options.headers() isKindOfClass:NSDictionary.class]) {
|
||||
|
||||
Reference in new issue
Block a user