Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add const annotations to LayoutAnimationKeyFrameManager

Browse Source 
Summary: Changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D25023706

fbshipit-source-id: 678377e2c471386670d1eab9c5adbe8aa6473a3c
This commit is contained in:
Samuel Susla
2020-11-18 06:57:10 -08:00
committed by Facebook GitHub Bot
parent 8cc44678ce
commit 312226362d
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp
+8 -8
View File
@@ -631,12 +631,12 @@ void LayoutAnimationKeyFrameManager::adjustDelayedMutationIndicesForMutation(
std::vector<std::tuple<AnimationKeyFrame, AnimationConfig, LayoutAnimation *>>
LayoutAnimationKeyFrameManager::getAndEraseConflictingAnimations(
SurfaceId surfaceId,
ShadowViewMutationList &mutations,
ShadowViewMutationList const &mutations,
bool deletesOnly) const {
std::vector<std::tuple<AnimationKeyFrame, AnimationConfig, LayoutAnimation *>>
conflictingAnimations{};
for (auto &mutation : mutations) {
for (auto const &mutation : mutations) {
if (deletesOnly && mutation.type != ShadowViewMutation::Type::Delete) {
continue;
}
@@ -785,7 +785,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
LOG(ERROR) << "BEGINNING DISPLAYING ONGOING inflightAnimations_!";
int i = 0;
int j = 0;
for (auto &inflightAnimation : inflightAnimations_) {
for (auto const &inflightAnimation : inflightAnimations_) {
i++;
j = 0;
if (inflightAnimation.completed) {
@@ -885,7 +885,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
std::vector<AnimationKeyFrame> keyFramesToAnimate;
std::vector<AnimationKeyFrame> movesToAnimate;
auto const layoutAnimationConfig = animation.layoutAnimationConfig;
for (auto &mutation : mutations) {
for (auto const &mutation : mutations) {
ShadowView baselineShadowView =
(mutation.type == ShadowViewMutation::Type::Delete ||
mutation.type == ShadowViewMutation::Type::Remove
@@ -1182,7 +1182,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
#endif
auto finalConflictingMutations = ShadowViewMutationList{};
for (auto &conflictingKeyframeTuple : conflictingAnimations) {
for (auto const &conflictingKeyframeTuple : conflictingAnimations) {
auto &keyFrame = std::get<0>(conflictingKeyframeTuple);
if (keyFrame.finalMutationForKeyFrame.hasValue()) {
auto &mutation = *keyFrame.finalMutationForKeyFrame;
@@ -1359,7 +1359,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
LOG(ERROR) << "No Animation: Queue up final conflicting animations";
#endif
ShadowViewMutationList finalMutationsForConflictingAnimations{};
for (auto &conflictingKeyframeTuple : conflictingAnimations) {
for (auto const &conflictingKeyframeTuple : conflictingAnimations) {
auto &keyFrame = std::get<0>(conflictingKeyframeTuple);
if (keyFrame.finalMutationForKeyFrame.hasValue()) {
PrintMutationInstruction(
@@ -1399,7 +1399,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
LOG(ERROR)
<< "No Animation: Adjust delayed mutations based on all finalMutationsForConflictingAnimations";
#endif
for (auto &mutation : finalMutationsForConflictingAnimations) {
for (auto const &mutation : finalMutationsForConflictingAnimations) {
if (mutation.type == ShadowViewMutation::Type::Remove ||
mutation.type == ShadowViewMutation::Type::Insert) {
adjustDelayedMutationIndicesForMutation(surfaceId, mutation);
@@ -1463,7 +1463,7 @@ LayoutAnimationKeyFrameManager::pullTransaction(
LOG(ERROR) << "FINISHING DISPLAYING ONGOING inflightAnimations_!";
int i = 0;
int j = 0;
for (auto &inflightAnimation : inflightAnimations_) {
for (auto const &inflightAnimation : inflightAnimations_) {
i++;
j = 0;
if (inflightAnimation.completed) {
ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h
+1 -1
View File
@@ -223,7 +223,7 @@ class LayoutAnimationKeyFrameManager : public UIManagerAnimationDelegate,
std::vector<std::tuple<AnimationKeyFrame, AnimationConfig, LayoutAnimation *>>
getAndEraseConflictingAnimations(
SurfaceId surfaceId,
ShadowViewMutationList &mutations,
ShadowViewMutationList const &mutations,
bool deletesOnly = false) const;
mutable std::mutex surfaceIdsToStopMutex_;