Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix nullsafe FIXMEs for JsonWriterHelper.java and mark nullsafe

Browse Source 
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.
Changelog: [Android][Fixed] Made JsonWriterHelper.java nullsafe

Reviewed By: alanleedev

Differential Revision: D72384060

fbshipit-source-id: ce41674cc5dbadcd70029396607ac046100e2be7
This commit is contained in:
Gijs Weterings
2025-04-09 09:07:30 -07:00
committed by Facebook GitHub Bot
parent c921732423
commit 30da6ca84a
1 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/JsonWriterHelper.java
+21 -12
View File
@@ -8,11 +8,14 @@
package com.facebook.react.bridge;
import android.util.JsonWriter;
import com.facebook.infer.annotation.Assertions;
import com.facebook.infer.annotation.Nullsafe;
import java.io.IOException;
import java.util.List;
import java.util.Map;
/** Helper for generating JSON for lists and maps. */
@Nullsafe(Nullsafe.Mode.LOCAL)
public class JsonWriterHelper {
public static void value(JsonWriter writer, Object value) throws IOException {
if (value instanceof Map) {
@@ -45,12 +48,14 @@ public class JsonWriterHelper {
writer.value(value.asString());
break;
case Map:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableMapValue(writer, value.asMap());
ReadableMap map = value.asMap();
Assertions.assertNotNull(map);
readableMapValue(writer, map);
break;
case Array:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableArrayValue(writer, value.asArray());
ReadableArray array = value.asArray();
Assertions.assertNotNull(array);
readableArrayValue(writer, array);
break;
default:
throw new IllegalArgumentException("Unknown data type: " + value.getType());
@@ -78,12 +83,14 @@ public class JsonWriterHelper {
writer.value(value.getString(key));
break;
case Map:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableMapValue(writer, value.getMap(key));
ReadableMap map = value.getMap(key);
Assertions.assertNotNull(map);
readableMapValue(writer, map);
break;
case Array:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableArrayValue(writer, value.getArray(key));
ReadableArray array = value.getArray(key);
Assertions.assertNotNull(array);
readableArrayValue(writer, array);
break;
default:
throw new IllegalArgumentException("Unknown data type: " + value.getType(key));
@@ -112,12 +119,14 @@ public class JsonWriterHelper {
writer.value(value.getString(key));
break;
case Map:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableMapValue(writer, value.getMap(key));
ReadableMap map = value.getMap(key);
Assertions.assertNotNull(map);
readableMapValue(writer, map);
break;
case Array:
// NULLSAFE_FIXME[Parameter Not Nullable]
readableArrayValue(writer, value.getArray(key));
ReadableArray array = value.getArray(key);
Assertions.assertNotNull(array);
readableArrayValue(writer, array);
break;
default:
throw new IllegalArgumentException("Unknown data type: " + value.getType(key));